Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[post-FxA Upgrade] Ensure LeanPlum push notification opt-in is working #6189

Closed
garvankeeley opened this issue Feb 27, 2020 · 4 comments
Closed
Assignees
Labels
5 Story size

Comments

@garvankeeley
Copy link
Contributor

garvankeeley commented Feb 27, 2020

Acceptance Criteria

  • Ensure Leanplum opt-in is working
  • Ensure that receiving push notifications when the app is not open is working

Background

Marketing currently has a campaign running that will reach users who have not opened the app in 45 days

Notes

LeanPlum had code for push notification opt-in that didn't appear useful, since we ask for that as part of Sync sign-in. Perhaps it was for non-Sync users to get push notifications? I have never seen the app doing that in the past. We will want to re-visit this and understand if there is work to do to setup LeanPlum.

https://github.com/mozilla-mobile/firefox-ios/blob/rust-integration/Client/Application/LeanplumIntegration.swift#L308

@project-bot project-bot bot added this to Needs Triage in Firefox iOS Development Feb 27, 2020
@athomasmoz athomasmoz moved this from Needs Triage to Up Next in Firefox iOS Development Feb 27, 2020
@athomasmoz athomasmoz added the 2 Story size label Feb 27, 2020
@garvankeeley
Copy link
Contributor Author

cc @nbhasin2

@athomasmoz athomasmoz moved this from Up Next to Sprint Backlog in Firefox iOS Development Apr 14, 2020
@athomasmoz athomasmoz added 5 Story size and removed 2 Story size labels Apr 14, 2020
@nbhasin2 nbhasin2 self-assigned this Apr 15, 2020
@nbhasin2 nbhasin2 moved this from Sprint Backlog to In Development in Firefox iOS Development Apr 16, 2020
@nbhasin2
Copy link
Contributor

Another find: This was defined for with an A/B test variable. Currently no A/B test is running and value of the variable to show this screen is set to false by default.

Below is how the notification looks like. Also, its a custom template In-app message notification from leanplum. This seems to be mainly for enabling push notification and why user should do it. It it sent from Leanplum to the device.

a) This is done by setting up template in the app see setupCustomTemplates() in LeanplumIntegration.swift

b) Once the template is setup, you can then go to messages send it. Currently it can be found under name FxA Prepush v1

Leanplum
image

In the app
image

@nbhasin2
Copy link
Contributor

Closing this as we have commented this code for now. This code is very specific to how we ask for users to allow for push notifications and is not necessarily required by FxA. We already prompt users to allow for push right after they sign in to Firefox iOS

We will revisit this as it is more for asking users to simply allow Notifications that will help FxA sync and send tabs to work properly in general.

Firefox iOS Development automation moved this from In Development to Needs QA Apr 27, 2020
@nbhasin2 nbhasin2 moved this from Needs QA to Done in Firefox iOS Development Apr 27, 2020
@nbhasin2
Copy link
Contributor

Ref: #5989

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 Story size
Projects
No open projects
Development

No branches or pull requests

3 participants