Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FXIOS-10 ⁃ Update colours in ETP shield icon #6711

Closed
AmyYLee opened this issue May 28, 2020 · 2 comments · Fixed by #6874
Closed

FXIOS-10 ⁃ Update colours in ETP shield icon #6711

AmyYLee opened this issue May 28, 2020 · 2 comments · Fixed by #6874
Labels
1 Story size access Relates to a11y features for users, such as Voice Over, Dynamic Type, Constrat, Readability, etc. eng-ready Ready to be picked up! P2 Issues that need to be completed after all P1 issues are completed for the current release QA Verified Issue verified by QA
Projects
Firefox iOS Development

Comments

@AmyYLee
Copy link
Collaborator

AmyYLee commented May 28, 2020 •
edited by data-sync-user

The colours in the ETP shield icon fails contrast test in Dark theme. For consistency we should use the same colouring for Light/Dark theme shield icon on iOS and Fenix. Please see below for colour reference and gradient direction

Screen Shot 2020-05-28 at 17 39 14

┆Issue is synchronized with this Jira Task
@AmyYLee AmyYLee added the Bug 🐞 This is a bug with existing functionality not behaving as expected label May 28, 2020
@project-bot project-bot bot added this to Needs Triage in Firefox iOS Development May 28, 2020
@AmyYLee AmyYLee added access Relates to a11y features for users, such as Voice Over, Dynamic Type, Constrat, Readability, etc. eng-ready Ready to be picked up! and removed access Relates to a11y features for users, such as Voice Over, Dynamic Type, Constrat, Readability, etc. Bug 🐞 This is a bug with existing functionality not behaving as expected labels May 28, 2020
@athomasmoz athomasmoz added P2 Issues that need to be completed after all P1 issues are completed for the current release 1 Story size access Relates to a11y features for users, such as Voice Over, Dynamic Type, Constrat, Readability, etc. labels Jun 4, 2020
@athomasmoz athomasmoz moved this from Needs Triage to Up Next in Firefox iOS Development Jun 4, 2020
@joeyg
Copy link
Contributor

joeyg commented Jun 27, 2020

@AmyYLee It looks like the shield icon colors come in the image. Would you be able to provide a new asset? https://github.com/mozilla-mobile/firefox-ios/blob/master/Client/Assets/Images.xcassets/tracking-protection-active-block.imageset/trackingprotection-medium.pdf

@q2r5 q2r5 mentioned this issue Jun 28, 2020
Merged
Firefox iOS Development automation moved this from Up Next to Needs QA Jun 29, 2020
@SimonBasca
Copy link
Contributor

Verified fixed on main 89b961b on iPhone XS max (13.4), sim iPhone 6 (12.2), sim iPad Pro 4th gen (13.x).

@SimonBasca SimonBasca added the QA Verified Issue verified by QA label Jun 30, 2020
@project-bot project-bot bot moved this from Needs QA to Done in Firefox iOS Development Jun 30, 2020
@data-sync-user data-sync-user changed the title Update colours in ETP shield icon FXIOS-10 ⁃ Update colours in ETP shield icon Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 Story size access Relates to a11y features for users, such as Voice Over, Dynamic Type, Constrat, Readability, etc. eng-ready Ready to be picked up! P2 Issues that need to be completed after all P1 issues are completed for the current release QA Verified Issue verified by QA
Projects
No open projects
Firefox iOS Development
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 6711: Update colours in ETP shield icon q2r5/firefox-ios
4 participants
@joeyg @AmyYLee @SimonBasca @athomasmoz