Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build system: ETP lists dependency is on Amazon S3 #6792

Closed
4 tasks
say-yawn opened this issue Jun 12, 2020 · 4 comments
Closed
4 tasks

Build system: ETP lists dependency is on Amazon S3 #6792

say-yawn opened this issue Jun 12, 2020 · 4 comments
Labels
Feature-Request This is a new feature that did not previously exist in the project

Comments

@say-yawn
Copy link
Contributor

say-yawn commented Jun 12, 2020

Why/User Benefit/User Problem

Currently Firefox iOS is generating their own tracking protection lists by grabbing the raw source from shavar-prod-lists and following a similar configuration as shavar-list-creation. However, the logic to generate the tracking protection lists can fall behind (see #5559 and #5968). I suggest that Firefox iOS gets the lists from Shavar services maintained S3 files. With this transition Firefox iOS can deprecate the script to generate their own tracking protection lists and only have to maintain the script to convert the tracking protection JSON files to iOS consumable files all the while always being guaranteed to get the latest tracking protection lists from Shavar.

Acceptance Criteria (how do I know when I’m done?)

  • For every new release, download tracking protection files in JSON format from Shavar maintained S3 files
  • Use these files to update the tracking protection lists
  • Remove the script generating tracking protection lists
  • ETP still works

Not included

┆Issue is synchronized with this Jira Task

@say-yawn say-yawn added the Feature-Request This is a new feature that did not previously exist in the project label Jun 12, 2020
@project-bot project-bot bot added this to Needs Triage in Firefox iOS Development Jun 12, 2020
@say-yawn
Copy link
Contributor Author

@garvankeeley I still need information on what lists you all were generating so I can make sure those files are available in S3

@garvankeeley garvankeeley changed the title Download JSON of tracking protection lists from S3 Build system: ETP lists dependancy is on Amazon S3 Jun 15, 2020
@garvankeeley garvankeeley changed the title Build system: ETP lists dependancy is on Amazon S3 Build system: ETP lists dependency is on Amazon S3 Jun 15, 2020
@garvankeeley
Copy link
Contributor

@garvankeeley I still need information on what lists you all were generating so I can make sure those files are available in S3

These files are specified here:
https://github.com/mozilla-mobile/firefox-ios/blob/master/content-blocker-lib-ios/ContentBlockerGen/Sources/ContentBlockerGen/main.swift#L13

@garvankeeley
Copy link
Contributor

garvankeeley commented Jun 15, 2020

  • For every new release, download tracking protection files in JSON format from Shavar maintained S3 files

Dependency management questions: With what URL? And, where is the URL updated?

  • Remove the script generating tracking protection lists

iOS requires a specific format that we maintain so full removal is not possible; IIUC the inputs to this processing step are changing; please describe these inputs and from that we can determine if the outputs are still supported.

However, the logic to generate the tracking protection lists can fall behind (see #5559 and #5968).

Those bugs are input changes to the iOS processing script, I would imagine any input changes involving files being added or removed will result in these types of changes. Can you explain?

@data-sync-user data-sync-user changed the title Build system: ETP lists dependency is on Amazon S3 FXIOS-511 ⁃ Build system: ETP lists dependency is on Amazon S3 Oct 17, 2020
@data-sync-user data-sync-user changed the title FXIOS-511 ⁃ Build system: ETP lists dependency is on Amazon S3 Build system: ETP lists dependency is on Amazon S3 Oct 19, 2022
@data-sync-user
Copy link
Collaborator

➤ Laurie Marceau commented:

Closing this since this won’t be fetched from an S3 bucket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature-Request This is a new feature that did not previously exist in the project
Projects
None yet
Development

No branches or pull requests

3 participants