Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to "reload without caching" (long press gesture on reload button) #7024

Closed
SimonBasca opened this issue Jul 23, 2020 · 17 comments · Fixed by #12231
Closed

Add ability to "reload without caching" (long press gesture on reload button) #7024

SimonBasca opened this issue Jul 23, 2020 · 17 comments · Fixed by #12231
Labels
Contributor Fix A contributor has fixed this issue. It might still be opened as we're waiting for final QA approval Contributor OK This is a good issue for contributors interested in helping the project Feature-Request This is a new feature that did not previously exist in the project P3 Issues that would be nice to have for the current release

Comments

@SimonBasca
Copy link
Contributor

SimonBasca commented Jul 23, 2020

Steps to reproduce:

Long press of the reaload button

Actual results:

A menu pops up showing
Request desktop version
Reload without tracking protection

Expected results:

Also allow to reload "without using the cache". Similarly to what Ctrl + F5 does on the desktop version.
This simplifies testing in webdevelopment and is an intuitive approach to desktop behaviour. Instead of having to navigate through the settings and delete all data of a website.

Via : https://bugzilla.mozilla.org/show_bug.cgi?id=1653811

┆Issue is synchronized with this Jira Task

@SimonBasca SimonBasca added the Feature-Request This is a new feature that did not previously exist in the project label Jul 23, 2020
@github-actions github-actions bot added this to Needs Triage in Firefox iOS Development Jul 23, 2020
@athomasmoz
Copy link

Idea - do this through a keyboard shortcut, as it's for a very savvy user

@athomasmoz athomasmoz added Contributor OK This is a good issue for contributors interested in helping the project P3 Issues that would be nice to have for the current release labels Jul 30, 2020
@data-sync-user data-sync-user changed the title Add ability to "reload without caching" (long press gesture on reload button) FXIOS-657 ⁃ Add ability to "reload without caching" (long press gesture on reload button) Aug 5, 2020
@AnxiousHoliday
Copy link

Hello, is this issue still valid btw? If so i'd like to be assigned this issue if possible.

@athomasmoz
Copy link

Hi @amereid thanks for offering to help! Yes, this problem is still relevant to solve, however we're testing a change that moves the refresh options into the page actions menu #6847 . Because of that, it might be good to start with the keyboard shortcut suggestion to solve this

@AnxiousHoliday
Copy link

I started looking at adding a keyboard shortcut for "reloading tab without cache" and i have one question, should tab.reloadFromOrigin() be triggered for a cache-less reload? I'm only wondering because command+r already triggers tab.reload which calls reloadFromOrigin() if there is no error page. This would make the new keyboard shortcut redundant since command+r would behave like the new keyboard shortcut.

@griffinreding
Copy link

Please close per #6009

@data-sync-user data-sync-user changed the title FXIOS-657 ⁃ Add ability to "reload without caching" (long press gesture on reload button) Add ability to "reload without caching" (long press gesture on reload button) Aug 22, 2022
@lmarceau lmarceau reopened this Oct 31, 2022
@lmarceau
Copy link
Contributor

Reopened since needs QA. It can be tested the shortcut appears in the discoverability shortcuts on iPad, and that the shortcuts Ctrl + F5 indeed reload the tabs without cache.

@data-sync-user data-sync-user added the Contributor Fix A contributor has fixed this issue. It might still be opened as we're waiting for final QA approval label Oct 31, 2022
@MincDev
Copy link
Contributor

MincDev commented Nov 2, 2022

Reopened since needs QA. It can be tested the shortcut appears in the discoverability shortcuts on iPad, and that the shortcuts Ctrl + F5 indeed reload the tabs without cache.

@lmarceau does this require something from my side?

@lmarceau
Copy link
Contributor

lmarceau commented Nov 2, 2022

@MincDev no! Our team of QA will be picking this up shortly to test the changes. Thanks

@data-sync-user
Copy link
Collaborator

➤ Simion Basca commented:

Marking as verified fix on 108 (22578).

Note that the shortcuts are not functional with magic trackpad. This issue is tracked at #12479 ( https://github.com/mozilla-mobile/firefox-ios/issues/12479|smart-link )

@efojs
Copy link

efojs commented Apr 2, 2023

Hi! Is it in production already? I have iOS 15.0.2, latest (available) Firefox (111.1?) and can't find/see it

@lmarceau
Copy link
Contributor

lmarceau commented Apr 3, 2023

@efojs yes it's supposed to be released. You don't see the shortcut when holding the cmd button? Does pressing ctrl + F5 reloads without cache?

@efojs
Copy link

efojs commented Apr 3, 2023

holding the cmd button?

On iOS? Is it for debug mode when paired with computer?
I thought it's for basic usage, just when you want hard reload.

@lmarceau
Copy link
Contributor

lmarceau commented Apr 3, 2023

The "reload without cache" keyboard shortcut works when you have a keyboard paired with your iOS device (either a phone or iPad). If you press ctrl + F5 it normally reloads without the cache. I was asking the last two questions since you mentioned you couldn't find the said feature.

@efojs
Copy link

efojs commented Apr 3, 2023

Oh, nice. Thank you. I don't have external keyboard.
I was looking for this: "long press gesture on reload button" (from the issue title).

@MincDev
Copy link
Contributor

MincDev commented Apr 3, 2023

Oh, nice. Thank you. I don't have external keyboard.

I was looking for this: "long press gesture on reload button" (from the issue title).

@efojs this was in my original PR, but the requirement was changed to the keyboard reload.

@efojs
Copy link

efojs commented Apr 3, 2023

It's a pity. Would be handy to have it on long tap or in the menu

But maybe I'm wrong and it always just hard reloads?

@lmarceau
Copy link
Contributor

lmarceau commented Apr 3, 2023

If you wish you can open another feature request and link to this one, since this one was modified then done/closed. Thank you for raising this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contributor Fix A contributor has fixed this issue. It might still be opened as we're waiting for final QA approval Contributor OK This is a good issue for contributors interested in helping the project Feature-Request This is a new feature that did not previously exist in the project P3 Issues that would be nice to have for the current release
Projects
None yet
8 participants