Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

Show GeckoView version on About page #2114

Closed
cpeterso opened this issue Feb 20, 2018 · 6 comments
Closed

Show GeckoView version on About page #2114

cpeterso opened this issue Feb 20, 2018 · 6 comments
Labels
Geckoview🦎 QAApproved testing meta label for all features/bugs requiring test
Milestone

Comments

@cpeterso
Copy link
Collaborator

We should display both the Focus app version and GeckoView's Gecko version on Focus's About page, including Gecko's build ID or date. This information will be helpful when people report Gecko-related bugs in Focus.

@ekager
Copy link
Contributor

ekager commented Feb 22, 2018

Note - we are adding a focus:debug page #1655 which may be a better place for engine info. There is a PR #2089 open.

@bbinto bbinto added this to the v5.0 milestone Feb 23, 2018
@cpeterso
Copy link
Collaborator Author

The following bug will add GeckoView version information to the GeckoRuntime:

https://bugzilla.mozilla.org/show_bug.cgi?id=1465939

@ekager
Copy link
Contributor

ekager commented Jun 4, 2018

I added a quick fix for this, grabbing the version from gradle and adding it to BuildConfig, but keeping this open for when information is in GeckoRuntime.

@cpeterso
Copy link
Collaborator Author

This bug probably doesn't need to block the Focus 7.0 milestone because Emily has a workaround and few users will need to know their GeckoView version. :)

@pocmo
Copy link
Contributor

pocmo commented Jun 28, 2018

Don't we display the GeckoView version on the about page already?

@bbinto
Copy link
Contributor

bbinto commented Jul 3, 2018

Alright, let's close this issue!

@bbinto bbinto closed this as completed Jul 3, 2018
@rpappalax rpappalax added testing meta label for all features/bugs requiring test QAReady flag for test read & needed eng:automation Build automation, Continuous integration, .. QAApproved and removed QAReady flag for test read & needed eng:automation Build automation, Continuous integration, .. labels Aug 2, 2018
@rpappalax rpappalax added testing meta label for all features/bugs requiring test and removed testing meta label for all features/bugs requiring test labels Aug 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Geckoview🦎 QAApproved testing meta label for all features/bugs requiring test
Projects
None yet
Development

No branches or pull requests

5 participants