Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

Add crash reporting via Sentry #2326

Closed
6 of 8 tasks
pocmo opened this issue Mar 19, 2018 · 9 comments
Closed
6 of 8 tasks

Add crash reporting via Sentry #2326

pocmo opened this issue Mar 19, 2018 · 9 comments
Assignees

Comments

@pocmo
Copy link
Contributor

pocmo commented Mar 19, 2018

Why

  • GeckoView cannot leverage GPS crash reporting
  • Baseline for comparing GPS crash reporting for WebView vs. Sentry crash reporting for GeckoView
  • Provide stable product for Gecko-view powered Klar
  • Better crash handling (e.g. search for crashes etc.)
  • With GeckoView we will need our own custom crash reporting and cannot rely on Google Play crash reporting anymore.

What/ Requirements:

  • Enable crash reporting with sentry for release builds
  • Use sentry instance hosted by Mozilla
  • Make sure that this works with GeckoView crash reporting (Bug 1433968) and native crashes show up in Sentry
  • Make Sentry DSN configurable at build time (like Adjust token)
  • Configure taskcluster to pick up Sentry DSN from secrets service and configure build
  • Figure out with product/ux/legal if/what user-facing toggles are needed
  • Document in wiki (see https://github.com/mozilla-mobile/firefox-ios/wiki/Crash-Reporting-with-Sentry)
  • Look into reporting to Sentry AND Google Play crash reporting

Acceptance Criteria (how do I know when I’m done?)

  • Crash reporting in Sentry is accurate
  • APT to view and analyze crash reporting
  • Receiving crash reporting by default (in Klar, currently crash reporting is connected to "share usage data" which is off by default in Klar)
@Sdaswani
Copy link

@bbinto Sentry is approved in our mobile products - can you confirm we don't need a separate toggle for this?

@Sdaswani
Copy link

If we do need a toggle @bbinto then we may need UX work from @brampitoyo

@brampitoyo
Copy link

Yes. If we need a toggle, then let me know. It will most likely by put under “Mozilla” (current structure) or under “Privacy & Security” → “Data Collection & Use” (future structure as explained in #2357).

It’s also possible for this toggle to be combined with “Send usage data”.

@mcomella
Copy link
Contributor

Firefox TV's requirements are fewer but our Sentry PR is up: mozilla-mobile/firefox-tv#429

@bbinto bbinto added size S 1 day or less of work size M 2-3 days of work and removed needs strings size S 1 day or less of work labels Apr 4, 2018
@ekager ekager self-assigned this Apr 5, 2018
@ekager
Copy link
Contributor

ekager commented Apr 6, 2018

@Sdaswani looks like we want to receive crash reporting by default, but since Klar is opt-in for all usage-data, we may need to create a new opt-out toggle for Focus+Klar.

@Sdaswani
Copy link

Sdaswani commented Apr 6, 2018

Can we just shut it off for Klar @ekager ?

@ekager
Copy link
Contributor

ekager commented Apr 6, 2018

Right, it can be shut off, but then we won't have crash reporting for Klar (and GeckoView) unless people opted in to usage data. I'm understanding from the above bullets that we want Crash reporting on by default, so we will need to introduce a new toggle. Is that right, @bbinto ?

@bbinto
Copy link
Contributor

bbinto commented Apr 9, 2018

I believe we agreed on that during Portland: for now as it relates to Klar and Focus, it should be included in the general data collection toggle, which indeed would not provide crash reporting for klar by default. For now, that's fine.

@ekager
Copy link
Contributor

ekager commented Apr 20, 2018

Closing this and opening new issues for:
-Make sure that this works with GeckoView crash reporting (Bug 1433968) and native crashes show up in Sentry
and
-Look into reporting to Sentry AND Google Play crash reporting

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants