Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

The "Remove" option from a shortcut is overlapping the shortcut when the keyboard is triggered #5514

Closed
lobontiumira opened this issue Sep 30, 2021 · 13 comments
Labels
bug compose Issues related to Jetpack Compose UX

Comments

@lobontiumira
Copy link

Steps to reproduce

  1. Install Focus v93.
  2. Add a shortcut to the homescreen.
  3. Go to the homescreen, and activate the keyboard.
  4. Long-tap on the shortcut, and observe the position of the "Remove" option.

Expected behavior

The "Remove" option is below the shortcut even when the keyboard is triggered.

Actual behavior

The "Remove" option from a shortcut is overlapping the shortcut when the keyboard is triggered.

Device information

  • Android device: Sony Xperia Z5 Premium (Android 7.1.1), Huawei P9 Lite (Android 8)
  • Focus version: 93.1.0 RC build, and on the latest debug build from main from 9/30
  • Not reproducible on Samsung Galaxy Note 8 (Android 9), on Samsung Galaxy Tab A6 (Android 5.1.1), nor on Xiaomi mi4i (Android 5.0.2)
remove.mp4
@mcarare mcarare added the compose Issues related to Jetpack Compose label Sep 30, 2021
@lobontiumira
Copy link
Author

This is still reproducible on RC 93.1.1 with the same devices: Sony Xperia Z5 Premium (Android 7.1.1), Huawei P9 Lite (Android 8).

@delia-pop
Copy link

delia-pop commented Oct 20, 2021

The issue is still present on Beta 94.0.0-beta.2 (build 352922038 GV 94.0-20211017185800) and the latest debug build from main 10/20 with Huawei P9 Lite (Android 8).

@lobontiumira
Copy link
Author

Still reproducible on Sony Xperia Z5 Premium (Android 7.1.1) on the latest Focus Nightly 95.0 (build 353061431 GV 95.0a1-20211101084651).

@delia-pop
Copy link

Reproducible on Beta 97.0.0-beta.5 with LG G7 fit (Android 8.1.0). The "Rename/Remove" option menu is displayed for a split second above the shortcut when tapped from the awesome bar.

20220126_131821_Trim.mp4

@lobontiumira
Copy link
Author

This issue still reproduces on all Focus builds (Nightly 102.0a1 from 5/26, Beta 101.0.0-beta.6, and RC 101.1.0) with Sony Xperia Z5 Premium (Android 7.1.1).
Not reproducible on Oppo Reno 6 (Android 12).

@iorgamgabriel iorgamgabriel added this to Backlog in Android Focus via automation Jul 25, 2022
@iorgamgabriel iorgamgabriel moved this from Backlog to Unprioritized in Android Focus Jul 25, 2022
@ionutbedregeanu ionutbedregeanu self-assigned this Aug 10, 2022
@ionutbedregeanu ionutbedregeanu moved this from Unprioritized to In Progress in Android Focus Aug 10, 2022
@ionutbedregeanu
Copy link
Contributor

@lobontiumira Can you please check if you can reproduce it? I didn't succeed on my side

@ionutbedregeanu ionutbedregeanu moved this from In Progress to Backlog in Android Focus Aug 10, 2022
@lobontiumira
Copy link
Author

@ionutbedregeanu this issue still reproduces on the latest Focus nightly 105.0a1 from 8/11 with Sony Xperia Z5 Premium (Android 7.1.1):

Untitled

@ionutbedregeanu ionutbedregeanu moved this from Backlog to In Progress in Android Focus Aug 12, 2022
@ionutbedregeanu
Copy link
Contributor

I succeed to reproduce it on my side on small devices, but compose DropdownMenu behaves by default like this when it doesn't have space to be extended, so I don't see how can I improve this. Maybe the UX team(@jeffreygee ) can help us with a solution

@ionutbedregeanu ionutbedregeanu moved this from In Progress to Unprioritized in Android Focus Aug 16, 2022
@lobontiumira
Copy link
Author

This issue still reproduces on the latest Focus nightly 107.0a1 from 10/6, and Beta 106.0b4, with Sony Xperia Z5 Premium (Android 7.1.1):

Untitled

@jeffreygee
Copy link

@lobontiumira I noticed this happens on Fenix too. The only suggestion I'd have to get around this is that we add an 'Open Shortcut' option to the menu.

cc: @rtestard any thoughts on this?

@rtestard
Copy link

On the screenshots it seems to have space to be extended though?
I cannot reproduce on my pixel 4a and it's unclear under which circumstances it reproduces - certain screen sizes?

@lobontiumira
Copy link
Author

@rtestard we were able to reproduce this only on:

  • Sony Xperia Z5 Premium (Android 7.1.1) that has these characteristics: 2160 x 3840 pixels, 16:9 ratio (~806 ppi density), and
  • Huawei P9 Lite (Android 7): 1080 x 1920 pixels (~432 ppi pixel density).

@cpeterso
Copy link
Collaborator

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1802250

Change performed by the Move to Bugzilla add-on.

Android Focus automation moved this from Unprioritized to Done Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug compose Issues related to Jetpack Compose UX
Projects
Android Focus
  
Done
Development

No branches or pull requests

7 participants