Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

Focus is wrongly listed in the share list when chosing to share by long tapping a link #6543

Closed
SoftVision-CiprianMuresan opened this issue Mar 1, 2022 · 9 comments
Assignees

Comments

@SoftVision-CiprianMuresan

[Affected Versions]:

  • Firefox Focus 97.2.0 (Build #360591303) GV: 97.0.1-20220216172458
  • Firefox Focus 98.0 (Build #360591110) GV: 98.0.20220224185616

[Affected Platforms]:

  • Android 9 (Samsung Galaxy S8)
  • Android 10 (Oneplus 6)
  • Android 8 (HUAWEI P20 lite)

[Steps to reproduce]:

  1. Open the Focus browser.
  2. Navigate to a page with links on it.
  3. Long tap one of the links and select the "Share Link" option.
  4. Observe the apps listed in the list.

[Expected result]:

  • Focus is not displayed in the app list.

[Actual result]:

  • The link can be shared with the Focus app.

[Notes]:

@indurs
Copy link
Contributor

indurs commented Mar 2, 2022

I can replicate the bug and will work on the issue

@Mugurell
Copy link
Contributor

Mugurell commented Mar 2, 2022

Thank you @indurs for the interest in this.
The issue might be a bit bigger though and common also to Fenix so I've created a new ticket in android-components to investigate and fix the issue there.

@indurs
Copy link
Contributor

indurs commented Mar 2, 2022

@Mugurell , that's fine. I would also like to contribute to this issue.

@Mugurell
Copy link
Contributor

Mugurell commented Mar 2, 2022

@indurs Sorry but that new issue was already assigned to a new colleague.
While there aren't recent issues triaged for new contributors you can pick any from the backlog - https://github.com/mozilla-mobile/focus-android/issues and we can offer guidance when starting to work on that.
Some triaged tickets which might be more welcoming to new contributors can be found on Fenix

@indurs
Copy link
Contributor

indurs commented Mar 2, 2022

Thank You @Mugurell . Will look into those issues

@lobontiumira
Copy link

Reproducible on Beta 99.0.0-beta.1 with Xiaomi mi4i (Android 5.0.2).

@delia-pop
Copy link

Reproducible on Beta 99.0.0-beta.4 with Google Pixel (Android 12).

@Mugurell
Copy link
Contributor

Fix should be available to test in the next Nightly.

@Mugurell Mugurell added the QAReady flag for test read & needed label Mar 22, 2022
@delia-pop
Copy link

Verified as fixed on the latest Focus Nightly 100.0a1 (Build 360830510 🦎 100.0a1-20220323094932) with Google Pixel 6 (Android 12), Xiaomi Redmi Note 8T (Android 9) and Huawei MediaPad M2 (Android 5.1.1). The current app is no longer listed in the share list.

@delia-pop delia-pop added QAVerified and removed QAReady flag for test read & needed labels Mar 24, 2022
@Mugurell Mugurell added this to the 100 milestone Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants