Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FVP-02-016 OAuth: Auth code could be leaked by injecting port #812

Closed
bakulf opened this issue Apr 7, 2021 · 1 comment
Closed

FVP-02-016 OAuth: Auth code could be leaked by injecting port #812

bakulf opened this issue Apr 7, 2021 · 1 comment
Labels
p2 Medium Criticality Issues

Comments

@bakulf
Copy link
Collaborator

bakulf commented Apr 7, 2021

When a user wants to log into Mozilla VPN, the VPN client will make a request to https://
vpn.mozilla.org/api/v2/vpn/login/windows to obtain an authorization URL. The endpoint
takes a port parameter that will be reflected in a !undefined! element after the user signs into
the web page. It was found that the port parameter can be of arbitrary value. Further, it is
possible to inject the @ sign, so that the request will go to an arbitrary host instead of
localhost. Theoretically, an attacker can give a crafted URL to a victim and once the
victim uses it to log in, their authorization code will be leaked to the attacker’s website.
However, the CSP in place contains a strict img-src directive which prevents
exploitation.

┆Issue is synchronized with this Jira Task

@bakulf bakulf added p2 Medium Criticality Issues audit-issue labels Apr 7, 2021
@bakulf
Copy link
Collaborator Author

bakulf commented Apr 8, 2021

I wrote a PR for this. See https://github.com/mozilla-services/guardian-website/pull/1105

@bakulf bakulf closed this as completed Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 Medium Criticality Issues
Projects
None yet
Development

No branches or pull requests

1 participant