This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Make the lint command check .jsx files too #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliperelman
reviewed
Sep 27, 2017
| @@ -37,6 +37,7 @@ const eslint = require('neutrino-middleware-eslint'); | |||
| // Usage shows default values | |||
| neutrino.use(eslint, { | |||
| test: /\.(js|jsx)$/, | |||
| extensions: ['js', 'jsx'], | |||
There was a problem hiding this comment.
Should these be part of the eslint options?
There was a problem hiding this comment.
The option will be ignored when used by eslint-loader, but yeah it probably belongs in eslint anyway. I'll update the PR and add a comment.
Previously the `neutrino lint` command would only check `.js` files, which was inconsistent with the build/start commands, since they use `eslint-loader` and so instead use the `test` regex of `/\.(js|jsx)$/`. Fixes #332.
|
The Travis failure appears unrelated. |
eliperelman
approved these changes
Sep 28, 2017
|
Thanks @edmorley! |
|
Released in v6.2.1. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
neutrino lintcommand would only check.jsfiles, which was inconsistent with the build/start commands, since they useeslint-loaderand so instead use thetestregex of/\.(js|jsx)$/.This now means there is redundancy in the eslint middleware options, however there isn't a reliable way to turn the
testregex into a flat array of file extensions.In a future major release, perhaps the eslint middleware could drop support for
options.testand instead only accept theoptions.extensionsarray, which could then be mapped back to thetestregex internally. However this would mean less flexible selection of files to be matched, plus mean that there would be inconsistent support foroptions.testbetween the various loader middlewares, so not sure whether it's the best way forwards anyway.Fixes #332.