Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restructure Balrog #1050

Open
bhearsum opened this issue Dec 20, 2019 · 0 comments
Open

restructure Balrog #1050

bhearsum opened this issue Dec 20, 2019 · 0 comments
Labels
admin admin app & api (aus4-admin.mozilla.org) public public Balrog app/api (aus5.mozilla.org; aus-api.mozilla.org)

Comments

@bhearsum
Copy link
Contributor

Balrog's design has evolved a bit over time, but some rough edges have crept in, particularly around having two applications share the same library. For example, it's very difficult to have global objects (such as a database), because the two applications live in different places (and for awhile, had their own database objects). We can work around that with hacks like in https://github.com/mozilla/balrog/blob/master/auslib/__init__.py, but it's not ideal.

I'm also finding that making caching only happen on the non-admin application as part of bug 671488 to be more complicated because of this.

In any case, it seems like we should be looking towards some sort of structure that allows the common parts of Balrog (db.py, blobs/, maybe AUS.py) to be in an importable library, and the app-specific parts to live in their own place. We'll have to consider what this means for deployment (particularly in cases where we need a synced deployment for admin+non-admin), and there might be better options than this too.

This is low on the priority list given the feature work on the horizon, but it would be nice to do for future maintainability.

(Imported from https://bugzilla.mozilla.org/show_bug.cgi?id=1109295)

@bhearsum bhearsum added admin admin app & api (aus4-admin.mozilla.org) public public Balrog app/api (aus5.mozilla.org; aus-api.mozilla.org) labels Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin admin app & api (aus4-admin.mozilla.org) public public Balrog app/api (aus5.mozilla.org; aus-api.mozilla.org)
Projects
None yet
Development

No branches or pull requests

1 participant