Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

download artifacts with temp_queue if possible #426

Open
escapewindow opened this issue Jan 28, 2020 · 2 comments · Fixed by #434 · May be fixed by #538
Open

download artifacts with temp_queue if possible #426

escapewindow opened this issue Jan 28, 2020 · 2 comments · Fixed by #434 · May be fixed by #538

Comments

@escapewindow
Copy link
Contributor

We currently download artifacts with queue, which uses the worker creds. This means for private artifacts, the worker clientId needs to have access to those private artifacts.

The temp_queue will be given access to private artifacts for those tasks that need them. So if we download artifacts with that, we no longer need to add private artifact support to the worker clientId. Let's do that.
@escapewindow escapewindow mentioned this issue Feb 21, 2020
Merged
@escapewindow escapewindow reopened this Feb 26, 2020
@escapewindow
Copy link
Contributor Author

We need to re-land, once we add the appropriate get-artifact scopes for all partners. https://bugzilla.mozilla.org/show_bug.cgi?id=1618138

@escapewindow
Copy link
Contributor Author

https://bugzilla.mozilla.org/show_bug.cgi?id=1594797#c3
#437

@escapewindow escapewindow linked a pull request May 3, 2022 that will close this issue
Draft
escapewindow added a commit to escapewindow/scriptworker that referenced this issue May 3, 2022
@escapewindow
use context.temp_queue to download artifacts
8474c4e 
Fixes mozilla-releng#426.
@escapewindow escapewindow mentioned this issue Aug 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@escapewindow