This repository has been archived by the owner on Sep 20, 2019. It is now read-only.
Bug 1146897 - Generate the list of all json files being exported #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for rule in app.url_map.iter_rules(): | ||
| url = str(rule) | ||
| if url.endswith(".json"): | ||
| links.append((url.replace("/json/", ""), url)) |
There was a problem hiding this comment.
url.replace() looks fragile to me. Can you replace it with os.path.basename(url)? Also I'd reverse the order in the tuple (url, filename) so you it looks LTR in the template.
sylvestre
force-pushed
the
export-list-file
branch
2 times, most recently
from
d6cb2df
to
832d962
Compare
sylvestre
force-pushed
the
export-list-file
branch
from
832d962
to
2f70c7c
Compare
rail
pushed a commit
that referenced
this pull request
Sep 28, 2015
Bug 1146897 - Generate the list of all json files being exported
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.