Skip to content
This repository has been archived by the owner on Sep 20, 2019. It is now read-only.

Bug 1289801 - Provide versioned URL for product details #86

Merged
merged 10 commits into from Jul 27, 2016

Conversation

sylvestre
Copy link
Collaborator

No description provided.

@pascalchevrel
Copy link
Contributor

if the idea is to provide the API version number through the URL and no longer as part of the JSON object, then these lines should probably be removed:
https://github.com/sylvestre/ship-it/blob/852106d5d4566fd4228b1a507aff38bfd77309b1/kickoff/jsonexport.py#L380
https://github.com/sylvestre/ship-it/blob/852106d5d4566fd4228b1a507aff38bfd77309b1/kickoff/jsonexport.py#L349

@@ -6,8 +6,8 @@
LATEST_FIREFOX_OLDER_VERSION = "3.6.28"
CURRENT_ESR = "45"
ESR_NEXT = ""
JSON_FORMAT_VERSION = 1
JSON_FORMAT_L10N_VERSION = 1
JSON_FORMAT_VERSION = 1.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a version number and for other version numbers in the config file, we stored them as string. if we don't intend to make calculations with these numbers, maybe we should store them as string, that would also avoid casting them to strings before using them in the template. A nitpick for consistency :)

@sylvestre
Copy link
Collaborator Author

Coverage increased (+0.1%) to 89.204%
Almost 90%!

@rail rail merged commit 9c4fb80 into mozilla-releng:master Jul 27, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants