Lambda function misses certain builds because of spaces

[peterbe]

@wlach discovered that when Firefox 60.0.1 was built yesterday only the ['linux-i686', 'linux-x86_64'] platforms were saved in Buildhub. Curious.

Compare: Windows and Linux.

One thing to notice is that the Windows filename contains spaces, the Linux one does not. The reason we think the cron job does not have a problem with this is because of that space. See this code from the cron job.

[peterbe]

For the record, if the S3 Event JSON looks like this:

{
    "Records": [
        {
            "eventTime": "2018-08-08T17:06:52.030Z",
            "s3": {
                "bucket": { "name": "archive-firefox" },
                "object": {
                    "key":
                        "pub/firefox/releases/60.0.1/win32/en-US/Firefox Setup 60.0.1.exe",
                    "size": 51001024
                }
            }
        }
    ]
}

...then it works.

But if it looks like this...:

{
    "Records": [
        {
            "eventTime": "2018-08-08T17:06:52.030Z",
            "s3": {
                "bucket": { "name": "archive-firefox" },
                "object": {
                    "key":
                        "pub/firefox/releases/60.0.1/win32/en-US/Firefox+Setup+60.0.1.exe",
                    "size": 51001024
                }
            }
        }
    ]
}

(note the difference on Firefox+Setup+60.0.1.exe vs Firefox Setup 60.0.1.exe.