Allow flapping plugin to retry indefinitely #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 12, 2013 13:00
Change the behavior of the flapping plugin's max_retry option to follow the same convention as the global max_retry option. If the option is set to -1, we keep retrying forever. Issue #519
|
Looks good ! Can you add yourself to NOTICE i - I'll merge then |
|
Here you go. Also sneaking in a git ignore for my editor if that's ok ;) |
|
Thanks :) |
almet
added a commit
that referenced
this pull request
Sep 12, 2013
Allow flapping plugin to retry indefinitely
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added some test for the existing code (not 100% coverage but better than nothing) and I've changed the max_retry option so that if we set it to -1, it retries indefinitely.
To test for restart, I wasn't able to mock the start call within the callback (looks like an interaction between mock and threading that I don't understand), so I've mocked the timer.