New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When deleting a collections, records are deleted but tombstone aren't #136
Merged
Natim
merged 3 commits into
master
from
136-when-deleting-a-collection-also-delete-tombstones
Jul 31, 2015
Merged
When deleting a collections, records are deleted but tombstone aren't #136
Natim
merged 3 commits into
master
from
136-when-deleting-a-collection-also-delete-tombstones
Jul 31, 2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same problem if you:
|
Same for collections.
|
Natim
changed the title
On deleting a collections, records are deleted but tombstone aren't
When deleting a collections, records are deleted but tombstone aren't
Jul 13, 2015
Needs mozilla-services/cliquet#400 to be merged first. |
r? @leplatrem @ametaireau |
LGTM ! Just wondering : why sometimes with_deleted and sometimes not ? |
@@ -118,16 +118,24 @@ def delete(self): | |||
storage = self.collection.storage | |||
parent_id = '/buckets/%s' % self.record_id | |||
storage.delete_all(collection_id='group', parent_id=parent_id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a with_deleted=False
Natim
force-pushed
the
136-when-deleting-a-collection-also-delete-tombstones
branch
from
July 30, 2015 14:14
0a15fbe
to
02be605
Compare
Natim
added a commit
that referenced
this pull request
Jul 31, 2015
…o-delete-tombstones When deleting a collections, records are deleted but tombstone aren't
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/mozilla-services/kinto/blob/master/kinto/views/collections.py#L31-L35