Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use everit-org/json-schema for schema validation tests #332

Closed
jklukas opened this issue May 8, 2019 · 2 comments · Fixed by #499
Closed

Use everit-org/json-schema for schema validation tests #332

jklukas opened this issue May 8, 2019 · 2 comments · Fixed by #499

Comments

@jklukas
Copy link
Contributor

jklukas commented May 8, 2019

The GCP pipeline is using the everit-org/json-schema Java library for schema validation and we should move testing of schemas to rely on that same library.

Currently, we test using hindsight (which I believe is using rapidjson for schema validation). We could run both testing implementations while we have both pipelines running concurrently.

Rapidjson's schema validator implements only v4 of the JSON schema specification and it ignores the "format" keyword. Moving completely to everit-org/json-schema would allow us to consider upgrading to the current v7 draft and taking better advantage of the "format" keyword for ensuring correct date and time types.

@jklukas
Copy link
Contributor Author

jklukas commented Aug 9, 2019

v7 also allows $comment fields, which would be useful for non-user-facing documention of schema templates.

@fbertsch
Copy link
Contributor

The edge-validator needs to be updated and re-deployed as well: https://github.com/mozilla-services/edge-validator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants