Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Commit

Permalink
Fix #3503, Use 'upload', not 'save', to mean upload. (#4963)
Browse files Browse the repository at this point in the history
  • Loading branch information
jaredhirsch committed Oct 30, 2018
1 parent f60cd2f commit 1ab37a5
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions locales/en-US/webextension.properties
Expand Up @@ -6,6 +6,7 @@ contextMenuLabel = Take a Screenshot
myShotsLink = My Shots
screenshotInstructions = Drag or click on the page to select a region. Press ESC to cancel.
saveScreenshotSelectedArea = Save
uploadScreenshotSelectedArea = Upload
saveScreenshotVisibleArea = Save visible
saveScreenshotFullPage = Save full page
cancelScreenshot = Cancel
Expand Down
8 changes: 4 additions & 4 deletions webextension/selector/ui.js
Expand Up @@ -420,9 +420,9 @@ this.ui = (function() { // eslint-disable-line no-unused-vars
data-l10n-title="downloadScreenshot"><img
src="${browser.extension.getURL("icons/download.svg")}" /></button>
<button class="preview-button-save"
data-l10n-title="saveScreenshotSelectedArea"><img
data-l10n-title="uploadScreenshotSelectedArea"><img
src="${browser.extension.getURL("icons/cloud.svg")}"
/>${browser.i18n.getMessage("saveScreenshotSelectedArea")}</button>`
/>${browser.i18n.getMessage("uploadScreenshotSelectedArea")}</button>`
}
</div>
</div>
Expand Down Expand Up @@ -727,8 +727,8 @@ this.ui = (function() { // eslint-disable-line no-unused-vars
const saveImg = makeEl("img");
saveImg.src = browser.extension.getURL("icons/cloud.svg");
save.appendChild(saveImg);
save.append(browser.i18n.getMessage("saveScreenshotSelectedArea"));
save.title = browser.i18n.getMessage("saveScreenshotSelectedArea");
save.append(browser.i18n.getMessage("uploadScreenshotSelectedArea"));
save.title = browser.i18n.getMessage("uploadScreenshotSelectedArea");
}
buttons.appendChild(download);
if (save) {
Expand Down

0 comments on commit 1ab37a5

Please sign in to comment.