Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Host images on an isolated domain #2300

Closed
jvehent opened this issue Mar 7, 2017 · 5 comments
Closed

Host images on an isolated domain #2300

jvehent opened this issue Mar 7, 2017 · 5 comments
Assignees
Labels
security Security issue: can be an active issue, or related to security hygene

Comments

@jvehent
Copy link
Contributor

jvehent commented Mar 7, 2017

Images must not be served via the main pageshot domain to reduce the risk of an image-based XSS stealing the user's cookies.

@jvehent jvehent added beta blocker security Security issue: can be an active issue, or related to security hygene labels Mar 7, 2017
@ianb ianb removed the beta blocker label Mar 7, 2017
@ianb ianb added this to the Page Shot in 54 milestone Mar 7, 2017
@dannycoates
Copy link
Contributor

Is there any dev work remaining for this?

@johngruen
Copy link
Contributor

@ianb bumping this issue. can we close?

@ianb
Copy link
Contributor

ianb commented May 17, 2017

Right now this is working because @relud setup an nginx response filter that rewrites image links to the new host. That's a pretty fragile solution, so we still need to do this properly. Probably all that means is using config.contentOrigin in the right place.

@ianb ianb self-assigned this May 17, 2017
@johngruen
Copy link
Contributor

@ianb should be add another row in the x-functional doc for this?

@ianb
Copy link
Contributor

ianb commented May 17, 2017

It's just normal server engineering, there's nothing exceptional about this. We've mitigated the security concern, but need to do some followup work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
security Security issue: can be an active issue, or related to security hygene
Projects
None yet
Development

No branches or pull requests

4 participants