Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Content with position:fixed isn't shot properly #3124

Open
crabel opened this issue Jul 14, 2017 · 7 comments
Open

Content with position:fixed isn't shot properly #3124

crabel opened this issue Jul 14, 2017 · 7 comments
Labels
defect firefox Something that has to ship in the add-on in Firefox
Milestone

Comments

@crabel
Copy link

crabel commented Jul 14, 2017

The following shot was taken at the following link:
https://www.google.com/culturalinstitute/beta/

As you can see in the shot, the fixed bar at the top isn't at the top, but placed in the content.
https://pageshot.net/GjIDqbauLAy0CM43/www.google.com

To replicate: Go to the url, scroll down, take a screenshot.
Note: The pageshot expires in a month. If that's not enough, I can extend it.

@johngruen
Copy link
Contributor

@crabel thanks for the report. I think this is probably b/c we aren't doing anything smart WRT fixed elements in shots, so they can wind up in arbitrary positions on full page shots.

@johngruen
Copy link
Contributor

@Vifespoir
Copy link

Without doing anything complicated, the CSS of the screenshot buttons could always keep them on screen. This way, people can scroll up to the position the they want the navbar to be.

@bnjbvr
Copy link

bnjbvr commented Dec 4, 2017

And yet another example, independently found by two different users at a local Firefox meetup: https://bugzilla.mozilla.org/show_bug.cgi?id=1422118

@ianb ianb added the defect label Jan 10, 2018
@ianb ianb removed this from the Stretch milestone Jan 10, 2018
@ianb ianb added the firefox Something that has to ship in the add-on in Firefox label Jan 11, 2018
@ghost ghost added this to the Stretch milestone Jan 29, 2018
@sillyonthestreet
Copy link

I still have the same issue with sticky headers or sticky chat buttons.

@ghost
Copy link

ghost commented May 22, 2018

Duplicate reported in Bugzilla @ https://bugzilla.mozilla.org/show_bug.cgi?id=1463458

@ghost
Copy link

ghost commented May 23, 2018

Ian filed #4487 which is closely related or dupe-ish of this, depending on how we solve it. It's not an easy problem, but that issue has a bunch of good details.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
defect firefox Something that has to ship in the add-on in Firefox
Projects
None yet
Development

No branches or pull requests

6 participants