Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Build dev bundles in development #3433

Closed
ianb opened this issue Aug 29, 2017 · 2 comments
Closed

Build dev bundles in development #3433

ianb opened this issue Aug 29, 2017 · 2 comments
Milestone

Comments

@ianb
Copy link
Contributor

ianb commented Aug 29, 2017

With #3432 we are no longer building hybrid development/production bundles, but instead build production builds all the time. It would be better if we built production bundles in production, and development builds in development.

To do this we need to add a flag to bin/build-scripts/bundle_dependencies for a dev or production build. A dev build doesn't uglify, uglifyify, and has NODE_ENV=dev. Then we should use bin/build-scripts/set_file to actually control the bundles, and make the generated file (the one that contains the flag value) a dependency for all bundles. Then we should make sure in bin/run-server it is set to dev, and in bin/release-version it is set to production.

@johngruen johngruen added this to the Stretch milestone Aug 31, 2017
@jaredhirsch
Copy link
Member

Moving into 57 milestone, because non-debuggable JS is an obstacle for contributors

@chenba
Copy link
Collaborator

chenba commented Oct 17, 2017

#3643 (PR of which has been merged) fixes part of this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants