Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Make sure full page warning and download-only warning play nicely together #3700

Closed
jaredhirsch opened this issue Oct 31, 2017 · 1 comment
Closed

Make sure full page warning and download-only warning play nicely together #3700

jaredhirsch opened this issue Oct 31, 2017 · 1 comment
Assignees
@jaredhirsch
Milestone
Sprint 0 (58-x) 🐘

Comments

@jaredhirsch
Copy link
Member

It occurs to me that both the full page 5000px limit warning and the download-only notice use the same positioning at the bottom of the overlay.

I'm guessing they will clash with each other right now.

We need guidance from UX on how to display multiple warnings on the preview screen.
@jaredhirsch jaredhirsch added this to the Sprint 0 (58-x) milestone Oct 31, 2017
@ghost ghost added the needs:UX label Oct 31, 2017
@johngruen
Copy link
Contributor

TL;DR don't show the height limit warning if you show the download warning.

@ianb ianb mentioned this issue Oct 31, 2017
Merged
@jaredhirsch jaredhirsch self-assigned this Nov 1, 2017
@ianb ianb closed this as completed in e3ee5af Nov 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jaredhirsch jaredhirsch

Labels
None yet
Projects
None yet
Milestone
Sprint 0 (58-x) 🐘
Development

No branches or pull requests
2 participants
@jaredhirsch @johngruen