Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmarks are not synced using a spanner account on iOS #341

Closed
tublitzed opened this issue Nov 18, 2019 · 5 comments
Closed

Bookmarks are not synced using a spanner account on iOS #341

tublitzed opened this issue Nov 18, 2019 · 5 comments
Assignees
Labels
bug Something isn't working p1 Stuff we gotta do before we ship!

Comments

@tublitzed
Copy link
Contributor

Via Stefan on Bugzilla #1597192:

Build:
Version 20.1 (16561);

Devices:

iPhone SE (13.1.2);
iPhone 11 (13.1.2).

Prerequisites

You are connected with multiple devices(Desktop/Android/iOS) on the same spanner account.

Steps to reproduce:

Make some browsing on the Android device(bookmarks, logins, history);
Sync on the Android device;
Sync the iOS;

Expected results
All your browsing data are synced on the iOS device.

Actual results
The bookmarks data are not synced on iOS using the spanner account.

Notes:

History and logins are synced properly;
The sync doesn't work in both directions for FF on iOS;
@tublitzed tublitzed added bug Something isn't working p1 Stuff we gotta do before we ship! labels Nov 18, 2019
@tublitzed tublitzed added this to Backlog: Misc in Services Engineering via automation Nov 18, 2019
@tublitzed tublitzed moved this from Backlog: Misc to Prioritized in Services Engineering Nov 18, 2019
@tublitzed tublitzed removed the p1 Stuff we gotta do before we ship! label Nov 18, 2019
@tublitzed tublitzed changed the title Bookmarks are not synced using a spanner account on iOS Bookmarks are not synced using a spanner account on iOS 13.1.2 Nov 18, 2019
@tublitzed tublitzed moved this from Prioritized to Backlog: Sync in Services Engineering Nov 18, 2019
@tublitzed
Copy link
Contributor Author

tublitzed commented Nov 25, 2019

Re-opening. Just confirmed this is still happening in at least one account in production (mine, sync id: 130387415) using firefox-ios 20.2. This is against Durable Sync 0.1.7

I'd guess that this is related to #342 which looks like an issue within the Rust components. That would explain why we're seeing some types of data sync (ie, History, which is a sync engine that is not yet wired to the Rust components) and not others.

@tublitzed tublitzed added the p1 Stuff we gotta do before we ship! label Nov 25, 2019
@tublitzed tublitzed moved this from Backlog: Sync to Prioritized in Services Engineering Nov 25, 2019
@tublitzed tublitzed changed the title Bookmarks are not synced using a spanner account on iOS 13.1.2 Bookmarks are not synced using a spanner account on iOS Nov 25, 2019
@tublitzed
Copy link
Contributor Author

FWIW, I'm going to test this one again later today after I get another test account (131750265) migrated over to spanner in prod. I've had some issues already with 130387415 so it's possible that what's happening there isn't happening to iOS across the board.

@tublitzed
Copy link
Contributor Author

Confirmed that this is happening against newly created account as well.

@tublitzed tublitzed moved this from Prioritized to Active in Services Engineering Dec 9, 2019
@tublitzed
Copy link
Contributor Author

tublitzed commented Dec 10, 2019

@pjenvey just tracked this down, which looks like we're not allowing ENV var/server config to override maxTotalRecords, which might explain this (ie, we hit spanner mut limit).

@tublitzed tublitzed moved this from Active to In Review in Services Engineering Dec 10, 2019
@tublitzed
Copy link
Contributor Author

Looks like this fix may have resolved this. Going to keep this one in review until we get QA signoff here in the related bugzilla issue.

@tublitzed tublitzed moved this from In Review to Done in Services Engineering Dec 11, 2019
@tublitzed tublitzed moved this from Done to Archived in Services Engineering Dec 16, 2019
Services Engineering automation moved this from Archived to Done Jan 3, 2020
@tublitzed tublitzed moved this from Done to Archived in Services Engineering Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p1 Stuff we gotta do before we ship!
Projects
Development

No branches or pull requests

2 participants