Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeepSpeech.py should show ERROR for bad flags #1931

Closed
JRMeyer opened this issue Mar 4, 2019 · 2 comments
Closed

DeepSpeech.py should show ERROR for bad flags #1931

JRMeyer opened this issue Mar 4, 2019 · 2 comments
Assignees
@JRMeyer

Comments

@JRMeyer
Copy link
Contributor

JRMeyer commented Mar 4, 2019

CURRENT BEHAVIOR:

if the user supplies a flag (e.g. --foo_flag) to DeepSpeech.py, and that flag does not exist in the flags defined in until/flags.py, nothing will happen at run-time (currently).

BETTER BEHAVIOR:

there should be some kind of error or warning message if user supplies an invalid flag
@JRMeyer JRMeyer self-assigned this Mar 4, 2019
@JRMeyer JRMeyer mentioned this issue Mar 19, 2019
Closed
@reuben
Copy link
Contributor

reuben commented Dec 4, 2019

Works for me. (Maybe fixed by the switch to absl-py?)

@reuben reuben closed this as completed Dec 4, 2019
@lock
Copy link

lock bot commented Jan 3, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Jan 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JRMeyer JRMeyer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@reuben @JRMeyer