Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox Color messed up my favorite theme (Find bar became irreversibly white) #1023

Closed
lucaspestana opened this issue Jun 13, 2022 · 3 comments

Comments

@lucaspestana
Copy link

lucaspestana commented Jun 13, 2022

I am a user of Firefox Developer Edition, I think it was at version 102. I am running Windows 10, version 21H2.
So here's what happened: I had Rayr's "Dark Space Full Transparent" theme installed; its code is also available on GitHub and it has been forked from another theme called "Dark Space" by Nicothin². It is a nearly all-black theme, sporting an animated dark UI (including a black/dark Find bar that popped when pressing Ctrl+F); it had been working perfectly fine for many months now.

Then, I got a notification saying Firefox now had a new feature called Firefox Color, which allows customization of the UI colors.

I hopped on tried and played around changing a few colors here and there. Then, dissatisfied with the results, I tried undoing a few of the changes I've made and it didn't work out well.
So, I clicked this cursed button: "Revert All" (the leftmost button on top).

After that, my theme glitched and got corrupted, and now the Find bar always appears in a milky-white color, instead of the theme's default black color. I am unable to undo or revert this one change, either from Color or from anywhere else.
Screenshot below also here or here.
image_2022_6_12_297

.

The Find bar should go back to the theme's default color, but it won't -- I just talked to @Rayrsn the developer himself, and this is what he has said to me over private messaging:

  • Alright, so from my understanding the element that controls the bottom toolbar is the same as the top search bar.
  • In Nicothin's version it's completely black. In my theme it's transparent, that's why it's showing the default gray color, or at least it should show it.
  • In your case I think it's bugged and it has replaced the default color with the milky white.
  • Getting kinda more technical: your problem should be impossible, because if there was a problem with my theme it should have also affected the top bar (both bars should have changed color); the only explanation I have for this is, that a certain bug is causing older assigned values to the bottom bar not getting overwritten by a transparent value.

.

I tried uninstalling and reinstalling the theme. It doesn't work.
I tried uninstalling the Firefox Color addon. Zero results.
I tried restoring Firefox. It didn't work either.
I tried fully uninstalling Firefox. Nope.
I tried disabling Firefox Sync. It took me a while to succeed in it, but it didn't solve my problem.
Finally, I tried uninstalling Developer Edition and using other editions of Firefox instead. The issue persists across different editions.

I then timidly tried reproducing corrupting another theme -- Nicothin's original "Dark Space" theme -- by having it installed and then playing around with Firefox Color customizing colors, and clicking "Undo" and "Revert All". It didn't work (fortunately), and the Find bar of "Dark Space" remains black, as it should be.

A number of other people I talked to suggested that I open about:support and then open my PC's "Profile directory" in Windows Explorer. I did it, I tried deleting or changing the extension's XPI file from there. It also doesn't work.

I have just tried contacting Rayr the developer; he was very kind in replying and tried looking into the code of both his theme and the original theme by Nicothin, but he found nothing he could fix on his end.

.

I suspect there must some setting buried down deep somewhere in my OS that must be affecting this one theme -- but I lack the technical knowledge to go for such a deep dive; and at this point, even if I had it, I'm starting to doubt whether it would really solve things or not.
What should I do? What files or settings do I need to dive into and change?

I know it may sound like a very trivial problem, but for me, it has become so annoying and aggravating that I don't even feel like using Firefox anymore.

PLEASE HELP ME. Thank you.

@lucaspestana
Copy link
Author

lucaspestana commented Jun 13, 2022

I have also posted this issue elsewhere -- most importantly:

@Rob--W
Copy link
Member

Rob--W commented Jun 15, 2022

Then, I got a notification saying Firefox now had a new feature called Firefox Color, which allows customization of the UI colors.

There is no notification recommending Firefox Color; the only place where Firefox Color is featured in the browser is at the theme management page in about:addons. This has been around for a few years. If there was anything new, then it was probably "Colorway".

Since the issue occurs without Firefox Color, and even after resetting Firefox, this is most likely not an issue with Firefox Color, but potentially a change in Firefox. I recommend to continue this discussion in the Bugzilla ticket that you've filed (https://bugzilla.mozilla.org/show_bug.cgi?id=1774054).

@Rob--W Rob--W closed this as completed Jun 15, 2022
@lucaspestana
Copy link
Author

lucaspestana commented Jun 15, 2022

Well, in that case, sorry for my miswording, it may not have technically been a "notification" per se after all; I'm pretty sure it wasn't a native Windows notification, nor one of those which appear at the corner of the screen.
Still, I would not have installed this add-on on my own if Firefox itself didn't start recommending it. It might well have been around for some time now, yet I've never heard about it before.
Maybe it was in the "Recommended" section of Addons/Themes; perhaps it was somewhere else, I honestly can't remember.

image
I believe what I saw was similar to this (I do remember the colorful doodles in the background of this thing that popped up in my screen); this screenshot is from version 94, in 2021, when (as you noted) it was still called "Colorways".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants