Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak add-on signing in deployment to re-use previously signed XPI if version hasn't changed #21

Open
lmorchard opened this issue Jan 31, 2018 · 1 comment
Labels
Priority: p4 Lower priority backlog

Comments

@lmorchard
Copy link
Contributor

Currently, all deployments of the site via the development branch attempt to sign the add-on build. This will fail if the add-on version hasn't been changed.

But, if nothing has changed in the add-on (i.e. no code, not the shared BG images), this is wasteful. Would be handy to tweak the deployment to just download and re-use an existing signed XPI from AMO. (We do this on Test Pilot, as an example.)

@johngruen johngruen added this to the Stretch 🙆‍♀️ milestone May 8, 2018
@caitmuenster caitmuenster added Priority: p2 Issues at this level should be fixed in the near term Priority: ? Need input for prioritization and removed Priority: p2 Issues at this level should be fixed in the near term labels Mar 22, 2019
@lmorchard lmorchard added Priority: p4 Lower priority backlog and removed Priority: ? Need input for prioritization labels Mar 22, 2019
@lmorchard
Copy link
Contributor Author

The only thing this issue prevents is continual automatic deployments to dev on commits to master. That would be nice to have, though I might say that having automatic master branch builds of the add-on signed could be seen as a negative by AMO folks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: p4 Lower priority backlog
Projects
None yet
Development

No branches or pull requests

4 participants