Add unit tests for summary fields

mq/plugins/stackdriver_audit.py

@@ -67,7 +67,7 @@ def onMessage(self, message, metadata):
                     newmessage["details"][key] = mappedvalue
 
         # This is redundant
-        newmessage["summary"] = "{0} called {1} on {2}".format(
+        newmessage["summary"] = "{0} executed {1} on {2}".format(
             newmessage["details"]["username"], newmessage["details"]["action"], newmessage["details"]["resourcename"]
         )
 

mq/plugins/stackdriver_gceactivity.py

@@ -67,7 +67,7 @@ def onMessage(self, message, metadata):
                     newmessage["details"][key] = mappedvalue
 
         # This is redundant
-        newmessage["summary"] = "{0} called {1} on {2}".format(
+        newmessage["summary"] = "{0} executed {1} on {2}".format(
             newmessage["details"]["username"], newmessage["details"]["action"], newmessage["details"]["resourcename"],
         )
 

requirements.txt

@@ -31,6 +31,7 @@ pymongo==3.6.1
 pynsive==0.2.6
 python-dateutil==2.6.1
 pytz==2017.3
+PyYAML==5.1.1
 requests-jwt==0.5.3
 requests==2.22.0
 rsa==3.1.4

tests/mq/plugins/test_stackdriver_audit.py

@@ -321,5 +321,6 @@ def test_stackdriver_audit_activity(self):
         assert result["details"]["resourcetype"] == "gce_instance"
         assert result["details"]["service"] == "compute.googleapis.com"
         assert result["details"]["username"] == "onceuponatime@inagalaxynottoofaraway.com"
+        assert result["summary"] == "onceuponatime@inagalaxynottoofaraway.com executed v1.compute.instances.reset on projects/mcd-001-252615/zones/us-west2-a/instances/mozdefdevvm1"
 
         assert "protoPayload" not in result["details"]

tests/mq/plugins/test_stackdriver_gceactivity.py

@@ -241,4 +241,5 @@ def test_stackdriver(self):
         assert result["utctimestamp"] == "2019-11-22T01:23:47.936931+00:00"
         assert result["details"]["username"] == "luke@or.not"
         assert result["details"]["service"] == "compute.googleapis.com"
+        assert result["summary"] == "luke@or.not executed compute.instances.reset on mozdefdevvm1"
         assert "jsonPayload" not in result["details"]