less cryptic errors : let's verify the data

[tarekziade]

When creating a DSKey, if the data does not have what it takes, it breaks without telling what's wrong

let's fix this. in the init I propose to add:

class DSKey(object):
    ...

    def __init__(self, data=None, obj=None):
        ...
        if obj:
            self.dsa = obj
        else:
            for key in ('p', 'q', 'g', 'y'):
                if key not in data:
                    raise ValueError('missing %s in data - %s' % (key, str(data.keys()) ))
            ....

Thoughts ?

[almet]

+1 for me, "explicit is better than implicit" ;)

[almet]

Fixed in e0823cf