Enable orphaned nodes editing #59
Conversation
…eatures/orphaned-nodes
example/missing-n-duplicate.scene
Outdated
| } | ||
| }, | ||
| "inherits": "./ArchitectureKit/Pillar1x3Rnd.gltf" | ||
| } |
There was a problem hiding this comment.
This doesn't actually demonstrate duplicate nodes.
| @@ -0,0 +1,97 @@ | |||
| export default class ConflictHandler { | |||
There was a problem hiding this comment.
Generally, if a module exports a single default class, I think we want the file name to match the class name.
| } | ||
| }; | ||
|
|
||
| setDuplicateStatus = newStatus => { |
There was a problem hiding this comment.
If a class member is only used internally, or meant for private use, we start them with an underscore. I think that applies to a few of the methods in this class. Also applies to properties like duplicateList.
| return this.duplicateList[name] > 1; | ||
| }; | ||
|
|
||
| getMissingStatus = () => { |
There was a problem hiding this comment.
Looks like this method is not used anywhere.
| }); | ||
| }; | ||
|
|
||
| checkResolvedMissinRoot = scene => { |
| this.setMissingStatus(newStatus); | ||
| return resolvedList; | ||
| }; | ||
| } |
There was a problem hiding this comment.
Nice job on refactoring this out into a class! It's much cleaner now.
| list.forEach(resolvedMissingRoot => { | ||
| this.props.editor.removeObject(resolvedMissingRoot); | ||
| }); | ||
| if (handler) { |
There was a problem hiding this comment.
Hmm, I guess we're doing this because new scenes don't have conflictHandlers? Maybe they should.
Doesn't have to be fixed in this PR, but this kind of if statement (without an else) could lead to some surprising bugs. Maybe just keep a mental note to come back to this.
Enable orphaned nodes editing
missing-n-duplicate.sceneandmissing-node2.scene)