Skip to content
This repository has been archived by the owner on Feb 29, 2020. It is now read-only.

Add l10n (or i18n, or whatever it is) #136

Closed
pdehaan opened this issue Feb 17, 2016 · 10 comments
Closed

Add l10n (or i18n, or whatever it is) #136

pdehaan opened this issue Feb 17, 2016 · 10 comments

Comments

@pdehaan
Copy link
Collaborator

pdehaan commented Feb 17, 2016

Currently we only have a small handful of localizable strings.

https://github.com/MozillaFoundation/mofo-example-app/issues/13 and https://github.com/mozilla/donate.mozilla.org/blob/master/docs/Localization.md may have a few pointers.

We've used http://l20n.org/ in other projects, but not sure how well that'll play w/ React and add-ons.


new_tab

@pdehaan
Copy link
Collaborator Author

pdehaan commented Feb 17, 2016

new_tab
Figure 2: The "Timeline/Activity Stream" page also has a few different strings which could be localized.

@k88hudson k88hudson added this to the 5. Post v1 milestone Feb 18, 2016
@k88hudson
Copy link
Contributor

Personally I like to use react-intl, it works pretty well; we will also need to find out where we will host strings/write a script to pull down translations. This will be a post-v1 item

@oyiptong
Copy link
Contributor

We'll need to get the strings localized. The first release is en-US only.

@gasolin
Copy link
Contributor

gasolin commented Mar 24, 2016

In my previous usage l20n works pretty good.
@zbraniecki do you have experience to have l20n work with React or add-ons?

@zbraniecki
Copy link

If activity-streams are going to be plugged into our l10n toolchain, react-intl will not work because it uses MessageFormat which is not supported by our toolchain.

l20n.js would be a better option, but I'm not sure if we already have react bindings. If we don't, we should add them and activity-stream may be a good project to make it happen :) @stasm ?

@oyiptong
Copy link
Contributor

We don't have any plans at the moment for a language other than en-US. The experiment is set to only run for that locale. We can think about longer term commitments when it comes the time to think about for a gecko implementation.

@stasm
Copy link

stasm commented Mar 24, 2016

I'm planning on adding experimental support for React to L20n and I'm looking for a project to test it :) I'd love to take this opportunity and use activity-streams in my research!

@oyiptong
Copy link
Contributor

excellent and great to hear :-)

@pdehaan
Copy link
Collaborator Author

pdehaan commented Apr 8, 2016

Ref: #429

@k88hudson
Copy link
Contributor

This is on hold for now, but linking to PR by @stasm for some ideas/prior work when we do get to this

@tspurway tspurway added the MVP label Jan 17, 2017
@Mardak Mardak added P3 and removed P4 labels Jan 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
MVP Included
Completed
Development

No branches or pull requests

9 participants