Skip to content
This repository has been archived by the owner on Feb 29, 2020. It is now read-only.

Confirm we have all regions requried for 56 Shield Study localized #2774

Closed
k88hudson opened this issue Jun 27, 2017 · 11 comments
Closed

Confirm we have all regions requried for 56 Shield Study localized #2774

k88hudson opened this issue Jun 27, 2017 · 11 comments

Comments

@k88hudson
Copy link
Contributor

k88hudson commented Jun 27, 2017

We need to confirm which locales are important to be 100% localized for landing in 56 with product, and make sure we have the strings localized.

@flodolo
Copy link
Collaborator

flodolo commented Jul 3, 2017

I'm still seeing several strings not available for translation (recent bookmarks, visit again sections). When are you planning to expose them for localization? I failed to spot any open issue for that.

@Mardak
Copy link
Member

Mardak commented Jul 3, 2017

There was a recent string addition a few days ago that will be in the mozilla-central version of the add-on soon: https://github.com/mozilla/activity-stream/pull/2812/files#diff-906742e1af7418eb557312dc9217f2f1

The "recent bookmarks" section is in the Test Pilot version, which is stopping development, and it's unclear how soon that will make it in to the mozilla-central version.

I can just export all of those (pin, recent, visit again, etc.) to get the strings localized sooner than later.

@flodolo
Copy link
Collaborator

flodolo commented Jul 3, 2017

I can just export all of those (pin, recent, visit again, etc.) to get the strings localized sooner than later.

That sounds like a good idea, unless we plan to add more in this cycle. Please tag me in the PR (I'll be on PTO next week, trying to keep up with emails but probably to avoid real work).

@Mardak
Copy link
Member

Mardak commented Jul 26, 2017

depends on what's needed for shield beta 56

@Mardak Mardak added the Blocked label Jul 26, 2017
@Mardak
Copy link
Member

Mardak commented Jul 26, 2017

Initial verbal example was en-US and de. Blocked on product decision of which exact locales for shield study.

@mariappopova
Copy link

We will include Tier 1 (US, Canada, Germany) and Tier 2 (UK, Russia, Poland, France) locales in 56.

@Mardak
Copy link
Member

Mardak commented Jul 27, 2017

Currently those pontoon statuses:
en-US: source strings
en-CA: doesn't exist but just uses en-US
de: 100%
en-GB: 91%
ru: 91%, remaining strings have suggestions
pl: 100%
fr: 100%
https://pontoon.mozilla.org/projects/activity-stream-new-tab/

@flodolo
Copy link
Collaborator

flodolo commented Jul 27, 2017

This is completely new to me: why are we not including other languages if they're completely localized?

That wasn't called out when we exposed the project for localization, and for what it's worth I strongly disagree with this approach.

EDIT: is this only for this specific Shield Experiment or it's going to happen for the feature itself?

@flodolo
Copy link
Collaborator

flodolo commented Jul 27, 2017

EDIT: is this only for this specific Shield Experiment or it's going to happen for the feature itself?

Never mind, received an explanation via IRC. The list above only applies to the Shield Study for 56.

@Mardak Mardak changed the title Confirm we have all regions requried for launch localized Confirm we have all regions requried for 56 Shield Study localized Jul 31, 2017
@Mardak
Copy link
Member

Mardak commented Jul 31, 2017

Sounds like zh-CN is being added for China (not sure about zh-TW). But in either case, these two locales are already 100% translated. And of the previously listed desired locales (en-US, de, ru, pl, fr, en-GB), they're all 100% translated except the migration strings for en-GB, which will fall back to en-US.

Default top sites approval are being tracked https://bugzilla.mozilla.org/show_bug.cgi?id=1385317
The various countries seem like they're mostly okay except unknown about China and Canada.

The large icons for those top sites are being worked on by design. https://github.com/mozilla/tippy-top-sites/pull/72

Some related issues:
#3003 for using de for various de-* locales
#2944 for getting icons for those default sites

Marking this closed for now

@Mardak Mardak closed this as completed Jul 31, 2017
@Mardak
Copy link
Member

Mardak commented Aug 2, 2017

United States / en-US
us

Canada / en-US
canada

Germany / de
germany

France / fr
france

Russia / ru
russia

Poland / pl
poland

United Kingdom / en-GB
uk

Global - Taiwan / zh-TW
taiwan

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants