Linux repacks detected as unofficial builds

[Mardak]

Also see https://bugzilla.mozilla.org/show_bug.cgi?id=1411867

const IS_UNOFFICIAL_BUILD = Services.prefs.getStringPref("app.update.channel") === "default";

The only pref using a custom _dev value right now:

activity-stream/system-addon/lib/ActivityStream.jsm

Lines 124 to 127 in 653ef03

	["telemetry", {
	title: "Enable system error and usage data collection",
	value: true,
	value_local_dev: false

So without a fix, we miss out on telemetry from these types of repacks.

[Mardak]

It was suggested to use MOZILLA_OFFICIAL instead of the channel.
http://searchfox.org/mozilla-central/source/toolkit/modules/AppConstants.jsm#42

[Mardak]

So, MOZILLA_OFFICIAL won't be the same behavior that we have now, which I suppose is the purpose of this bug. @k88hudson, where do we want value_local_dev prefs to be set differently? Here's the differences in AppConstants among various builds:

local:

"NIGHTLY_BUILD": true,
"RELEASE_OR_BETA": false,
"MOZILLA_OFFICIAL": false,
"MOZ_OFFICIAL_BRANDING": false,
"MOZ_DEV_EDITION": false,
"MOZ_TELEMETRY_REPORTING": false,
"MOZ_TELEMETRY_ON_BY_DEFAULT": false,
"MOZ_REQUIRE_SIGNING": false,
"MOZ_ALLOW_LEGACY_EXTENSIONS": true,
"MOZ_UPDATE_CHANNEL": "default",
"SOURCE_REVISION_URL": "",

try:

"NIGHTLY_BUILD": true,
"RELEASE_OR_BETA": false,
"MOZILLA_OFFICIAL": true,
"MOZ_OFFICIAL_BRANDING": false,
"MOZ_DEV_EDITION": false,
"MOZ_TELEMETRY_REPORTING": false,
"MOZ_TELEMETRY_ON_BY_DEFAULT": false,
"MOZ_REQUIRE_SIGNING": false,
"MOZ_ALLOW_LEGACY_EXTENSIONS": true,
"MOZ_UPDATE_CHANNEL": "default",
"SOURCE_REVISION_URL": "https://hg.mozilla.org/try/rev/…",

autoland:

"NIGHTLY_BUILD": true,
"RELEASE_OR_BETA": false,
"MOZILLA_OFFICIAL": true,
"MOZ_OFFICIAL_BRANDING": false,
"MOZ_DEV_EDITION": false,
"MOZ_TELEMETRY_REPORTING": true,
"MOZ_TELEMETRY_ON_BY_DEFAULT": true,
"MOZ_REQUIRE_SIGNING": false,
"MOZ_ALLOW_LEGACY_EXTENSIONS": true,
"MOZ_UPDATE_CHANNEL": "default",
"SOURCE_REVISION_URL": "https://hg.mozilla.org/integration/autoland/rev/…",

nightly:

"NIGHTLY_BUILD": true,
"RELEASE_OR_BETA": false,
"MOZILLA_OFFICIAL": true,
"MOZ_OFFICIAL_BRANDING": false,
"MOZ_DEV_EDITION": false,
"MOZ_TELEMETRY_REPORTING": true,
"MOZ_TELEMETRY_ON_BY_DEFAULT": true,
"MOZ_REQUIRE_SIGNING": false,
"MOZ_ALLOW_LEGACY_EXTENSIONS": true,
"MOZ_UPDATE_CHANNEL": "nightly",
"SOURCE_REVISION_URL": "https://hg.mozilla.org/mozilla-central/rev/…",

aurora:

"NIGHTLY_BUILD": false,
"RELEASE_OR_BETA": true,
"MOZILLA_OFFICIAL": true,
"MOZ_OFFICIAL_BRANDING": false,
"MOZ_DEV_EDITION": true,
"MOZ_TELEMETRY_REPORTING": true,
"MOZ_TELEMETRY_ON_BY_DEFAULT": false,
"MOZ_REQUIRE_SIGNING": false,
"MOZ_ALLOW_LEGACY_EXTENSIONS": true,
"MOZ_UPDATE_CHANNEL": "aurora",
"SOURCE_REVISION_URL": "https://hg.mozilla.org/releases/mozilla-beta/rev/…",

beta:

"NIGHTLY_BUILD": false,
"RELEASE_OR_BETA": true,
"MOZILLA_OFFICIAL": true,
"MOZ_OFFICIAL_BRANDING": true,
"MOZ_DEV_EDITION": false,
"MOZ_TELEMETRY_REPORTING": true,
"MOZ_TELEMETRY_ON_BY_DEFAULT": false,
"E10S_TESTING_ONLY": false,
"MOZ_REQUIRE_SIGNING": true,
"MOZ_ALLOW_LEGACY_EXTENSIONS": false,
"MOZ_UPDATE_CHANNEL": "beta",
"SOURCE_REVISION_URL": "https://hg.mozilla.org/releases/mozilla-beta/rev/…",

release:

"NIGHTLY_BUILD": false,
"RELEASE_OR_BETA": true,
"MOZILLA_OFFICIAL": true,
"MOZ_OFFICIAL_BRANDING": true,
"MOZ_DEV_EDITION": false,
"MOZ_TELEMETRY_REPORTING": true,
"MOZ_TELEMETRY_ON_BY_DEFAULT": false,
"E10S_TESTING_ONLY": false,
"MOZ_REQUIRE_SIGNING": true,
"MOZ_ALLOW_LEGACY_EXTENSIONS": false,
"MOZ_UPDATE_CHANNEL": "release",
"SOURCE_REVISION_URL": "https://hg.mozilla.org/releases/mozilla-release/rev/…",

[Mardak]

Got confirmation that we just care about actually local developer builds getting special prefs.

[Mardak]

https://hg.mozilla.org/releases/mozilla-beta/rev/7fe3a16c32f7