Skip to content
This repository has been archived by the owner on Feb 29, 2020. It is now read-only.

feat(content) #45 top sites ui component #57

Closed
wants to merge 2 commits into from
Closed

Conversation

rlr
Copy link
Contributor

@rlr rlr commented Feb 5, 2016

  • I copied then tweaked a bunch of the styles from RNT
  • Should I name it Tiles instead of TopSites?
  • This is probably missing some needed media queries but it's hard to know until the rest of the components are laid out

r? @k88hudson

@rlr
Copy link
Contributor Author

rlr commented Feb 5, 2016

^^ the eslint check dislikes the test code... How do I fix that?

@k88hudson
Copy link
Contributor

Awesome! Can you add back the content-test to eslint and add the following to "rules":

    "react/jsx-uses-react": 1

and the following to "env":

"mocha": true

@k88hudson
Copy link
Contributor

R+ after that

@rlr rlr closed this Feb 5, 2016
@rlr rlr deleted the gh45/top-sites branch February 5, 2016 22:55
@rlr
Copy link
Contributor Author

rlr commented Feb 5, 2016

done 🍻

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants