Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a lint rule to disallow .ts files, enforce .tsx #75

Closed
kumar303 opened this issue Jan 29, 2019 · 1 comment · Fixed by #74
Closed

Add a lint rule to disallow .ts files, enforce .tsx #75

kumar303 opened this issue Jan 29, 2019 · 1 comment · Fixed by #74
Assignees
@willdurand
Labels
component:code_quality priority:p3 state:pull_request_ready
Projects
Add-ons Q1 2019: Code Review App
Milestone
2019.02.07

Comments

@kumar303
Copy link
Contributor

We want to always create .tsx files, not .ts files. This reduces the mental burden of trying to figure out which file to create. This lint rule is important because our lint command in #74 will ignore .ts files.
@kumar303 kumar303 mentioned this issue Jan 29, 2019
Merged
@willdurand willdurand self-assigned this Jan 30, 2019
@willdurand
Copy link
Member

willdurand commented Jan 30, 2019 •
edited
Loading

Could be done with https://www.npmjs.com/package/eslint-plugin-filenames actually nope

@willdurand willdurand mentioned this issue Jan 30, 2019
Merged
@willdurand willdurand added this to the 2019.02.07 milestone Jan 30, 2019
@willdurand willdurand moved this from To do to In progress in Add-ons Q1 2019: Code Review App Jan 31, 2019
Add-ons Q1 2019: Code Review App automation moved this from In progress to Done Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@willdurand willdurand

Labels
component:code_quality priority:p3 state:pull_request_ready
Projects
No open projects
Add-ons Q1 2019: Code Review App
  
Done
Milestone
2019.02.07
Development

Successfully merging a pull request may close this issue.

Configure ESLint mozilla/addons-code-manager
2 participants
@kumar303 @willdurand