URL with kanji results in 404

[ioanarusiczki]

I assume it is a regression caused by something on the next milestone (05.05.2022)

STR:

1. From edit page of an addon that uses kanji in the name click on View Product Page

https://addons-dev.allizom.org/en-US/developers/addon/%E6%BC%A2%E5%AD%97%E6%BC%A2%E5%AD%97%E6%BC%A2%E5%AD%97%E5%AD%A6%E5%B9%B4%E5%88%A5%E6%BC%A2%E5%AD%97%E9%85%8D%E5%BD%93%E8%A1%A814/edit

Actual result:
404 page

Expected result:
The detail page should be displayed because the addon has been approved

Notes:
not reproducible on AMO stage, it is only reproducible on AMO dev
only reproducible with kanji addons
cc @diox

[diox]

This isn't tied to clicking on the link in devhub - this gotta be a frontend issue.

• The API works: https://addons-dev.allizom.org/api/v5/addons/addon/漢字漢字漢字学年別漢字配当表14/
• https://addons-dev.allizom.org/en-US/firefox/addon/漢字漢字漢字学年別漢字配当表14/ 404s
• https://addons-dev.allizom.org/en-US/firefox/addon/621499/ correctly redirects to /en-US/firefox/addon/%E6%BC%A2%E5%AD%97%E6%BC%A2%E5%AD%97%E6%BC%A2%E5%AD%97%E5%AD%A6%E5%B9%B4%E5%88%A5%E6%BC%A2%E5%AD%97%E9%85%8D%E5%BD%93%E8%A1%A814/ (which should be equivalent to /en-US/firefox/addon/漢字漢字漢字学年別漢字配当表14/) which 404s

[diox]

Locally, I see this which is suspicious:
[2] [1651139258663] DEBUG (proxy/519696 on fiber): 404 ~> https://addons-dev.allizom.org/api/v5/addons/addon/%C3%A6%C2%BC%C2%A2%C3%A5%C2%AD%C2%97%C3%A6%C2%BC%C2%A2%C3%A5%C2%AD%C2%97%C3%A6%C2%BC%C2%A2%C3%A5%C2%AD%C2%97%C3%A5%C2%AD%C2%A6%C3%A5%C2%B9%C2%B4%C3%A5%C2%88%C2%A5%C3%A6%C2%BC%C2%A2%C3%A5%C2%AD%C2%97%C3%A9%C2%85%C2%8D%C3%A5%C2%BD%C2%93%C3%A8%C2%A1%C2%A814/?app=firefox&appversion=101.0&show_grouped_ratings=true&lang=en-US å½è¡¨14/ (status: 404)00] WARN (amo/519793 on fiber): Failed to load add-on with slug 漢字漢字漢字学年別漢字配当表14: Error: Error calling: /api/v5/addons/addon/æ¼¢å­æ¼¢å­æ¼¢å­å­¦å¹´å¥æ¼¢å­é [1] amo_request_id: "47ed8a79-c0cb-4797-a898-d063ab096367"

Note how the API call is incorrect.

[diox]

Bisected down to 0dc0fe4896aa1bb4c855fb5b0c8500cb3c600820 which passes tests and should have been just a minor upgrade, but evidently wasn't...

[diox]

See also:

• "Server Error" page displayed while page refresh for some add-ons #10169
• Cannot load an add-on on the client side but it works on the server #10765

QA: When verifying the fix for this issue we should also ensure these issues have not regressed either. Play around with add-on slugs that have non ascii characters, try to navigate to their detail pages directly, or from search results, reloading the page etc.

[ioanarusiczki]

@diox I'm still investigating about non ascii slugs (but seems to be working).
Right now all category pages are throwing a 404. Same for the tags (from the detail pages)

[ioanarusiczki]

@diox the query search https://addons-dev.allizom.org/en-US/firefox/search/?q=%E6%BC%A2%E5%AD%97%E6%BC%A2%E5%AD%97%E6%BC%A2%E5%AD%97%E5%AD%A6%E5%B9%B4%E5%88%A5%E6%BC%A2%E5%AD%97%E9%85%8D%E5%BD%93%E8%A1%A8

is failing right now, I get a 404

I've uploaded many addons with kanji like this one https://addons-dev.allizom.org/en-US/firefox/addon/%E6%BC%A2%E5%AD%97%E6%BC%A2%E5%AD%97%E6%BC%A2%E5%AD%97%E5%AD%A6%E5%B9%B4%E5%88%A5%E6%BC%A2%E5%AD%97%E9%85%8D%E5%BD%93%E8%A1%A814/

P.S. also another example would be this addon used as query search on -dev: https://addons-dev.allizom.org/en-US/firefox/addon/%D9%87%D8%B0%D8%A7-%D9%86%D8%B5-%D8%B7%D9%88%D9%8A%D9%84-%D8%AC%D8%AF%D8%A7/
the autocomplete will not return results
Meanwhile the same search on stage is working as expected.

[bobsilverberg]

I am hoping that mozilla/addons-frontend#11450 will fix these issues as well.

[ioanarusiczki]

@bobsilverberg @diox Looks good to me now. Verified on AMO dev - FF 99(Win10)