Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the desktop footer #10449

Closed
tofumatt opened this issue Jun 5, 2017 · 3 comments · Fixed by mozilla/addons-frontend#2524
Closed

Implement the desktop footer #10449

tofumatt opened this issue Jun 5, 2017 · 3 comments · Fixed by mozilla/addons-frontend#2524
Assignees
@tofumatt
Labels
migration:no-jira migration:2024 project:desktop_pages project: 2017 Q2 repository:addons-frontend Issue relating to addons-frontend state:verified_fixed
Milestone
2017.06.15

Comments

@tofumatt
Copy link
Contributor

tofumatt commented Jun 5, 2017 •
edited

We should change the footer colour over to match the header, and implement the new style from the mocks. (Minus the "view mobile site" link because the site will be responsive. Actually that link should be "Leave AMO beta" on desktop and "View Desktop Site" on mobile sizes...)

screenshot 2017-06-05 17 39 54
@tofumatt tofumatt self-assigned this Jun 5, 2017
tofumatt referenced this issue in mozilla/addons-frontend Jun 6, 2017
@tofumatt
feat: New Footer (fix #2518)
2175b55
@tofumatt tofumatt mentioned this issue Jun 6, 2017
Merged
tofumatt referenced this issue in mozilla/addons-frontend Jun 12, 2017
@tofumatt
feat: New Footer (fix #2518)
864469b
@tofumatt
Copy link
Contributor Author

Update: I've changed the text to "View Classic Desktop Site"

@tofumatt
Copy link
Contributor Author

To be clear the mobile site should have the logo on the left.

screen shot 2017-06-13 at 16 38 04

@vcarciu
Copy link

vcarciu commented Jun 13, 2017

Based on the latest comments, I will mark this as verified :
Desktop:
deskfooter

Mobile:
mobilefooter

@tofumatt tofumatt mentioned this issue May 5, 2024
Closed
10 tasks
@KevinMind KevinMind transferred this issue from mozilla/addons-frontend May 5, 2024
@KevinMind KevinMind added repository:addons-frontend Issue relating to addons-frontend migration:2024 labels May 5, 2024
@willdurand willdurand mentioned this issue May 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tofumatt tofumatt

Labels
migration:no-jira migration:2024 project:desktop_pages project: 2017 Q2 repository:addons-frontend Issue relating to addons-frontend state:verified_fixed
Projects
None yet
Milestone
2017.06.15
Development

Successfully merging a pull request may close this issue.

feat: New Footer mozilla/addons-frontend
4 participants
@tofumatt @vcarciu @addons-robot @KevinMind