Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose the Addon size in the Add-on metadata #3900

Closed
muffinresearch opened this issue Nov 14, 2017 · 9 comments · Fixed by #8229
Closed

Expose the Addon size in the Add-on metadata #3900

muffinresearch opened this issue Nov 14, 2017 · 9 comments · Fixed by #8229
Labels
contrib:assigned contrib:good_first_bug contrib:mentor_assigned size:S state:verified_fixed triaged
Milestone
2019.07.04

Comments

@muffinresearch
Copy link
Contributor

Refiled from mozilla/addons#535

On the old site we exposed the add-on download size.

ublock_origin____add-ons_for_firefox

However, in the new frontend this detail is missing. It's useful for knowing the size of the download ahead of time so it would be good to re-instate this data.
@muffinresearch muffinresearch mentioned this issue Nov 14, 2017
Closed
@muddlebee
Copy link

@muffinresearch how to expose this? Make it like blue or dark black?

@muffinresearch
Copy link
Contributor Author

@anweshknayak as a starting point it can follow the other metadata e.g how version is exposed:

adblock_plus_ _add-ons_for_firefox

@muffinresearch
Copy link
Contributor Author

@anweshknayak how are you going with this? Please let us know if you have any questions.

@muddlebee
Copy link

hey @ryanfeeley I couldn't locate this one. If I tried getting into this page it took me to the production one.

@jvillalobos
Copy link
Contributor

Mentor: @willdurand

@rpl
Copy link
Member

rpl commented May 15, 2019

The file size is provided by the Addon Version Detail api endpoint.

@divakarvenu
Copy link

Hi, can i take this as my first contribution?

@caitmuenster
Copy link

Hey @divakarvenu, welcome! You can absolutely take this bug up. We'll officially assign this to you once you have a PR up. :)

@rohitsanj rohitsanj mentioned this issue May 25, 2019
Closed
6 tasks
@voronianski voronianski mentioned this issue Jun 29, 2019
Merged
3 tasks
@willdurand willdurand added this to the 2019.07.04 milestone Jul 2, 2019
@AlexandraMoga
Copy link

Verified fixed on stage with Fx67, Win10x64
The version size is now exposed in the More information section on the addon details page and on All versions page:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contrib:assigned contrib:good_first_bug contrib:mentor_assigned size:S state:verified_fixed triaged
Projects
None yet
Milestone
2019.07.04
10 participants
@muffinresearch @rpl @jvillalobos @willdurand @wagnerand @divakarvenu @muddlebee @addons-robot @caitmuenster @AlexandraMoga