Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rating component often requires margin-left: -3px; it may need a flag for style or change to default CSS #4573

Closed
tofumatt opened this issue Mar 16, 2018 · 1 comment
Closed

Rating component often requires margin-left: -3px; it may need a flag for style or change to default CSS #4573

tofumatt opened this issue Mar 16, 2018 · 1 comment
Assignees
@kumar303
Labels
component:add-on_ratings component:code_quality size:S state:verified_fixed triaged
Milestone
2018.08.16

Comments

@tofumatt
Copy link
Contributor

tofumatt commented Mar 16, 2018 •
edited by kumar303

As mentioned in #4469 (comment), our Rating component is often in need of margin-left: -3px which seems like a code smell. I think it's from its original placement requiring some margin and every other component overriding that behaviour.

For QA: see #5900 for a testing plan. Note that the same patch is going to close both issues.
@tofumatt tofumatt mentioned this issue Mar 16, 2018
Merged
@kumar303 kumar303 self-assigned this Aug 9, 2018
@kumar303 kumar303 added this to the 2018.08.16 milestone Aug 9, 2018
@kumar303 kumar303 mentioned this issue Aug 10, 2018
Merged
@ioanarusiczki
Copy link

Issue #5900 was verified with FF61(Win10) on AMO dev.
@tofumatt I looked with the Inspector to search for some values for the margin left but it's -12px or 0 px.
Please take a look:
card contents

metadata card

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kumar303 kumar303

Labels
component:add-on_ratings component:code_quality size:S state:verified_fixed triaged
Projects
None yet
Milestone
2018.08.16
Development

No branches or pull requests
4 participants
@kumar303 @tofumatt @addons-robot @ioanarusiczki