Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit collection page closes when the language is changed #6341

Closed
ioanarusiczki opened this issue Sep 21, 2018 · 4 comments
Closed

Edit collection page closes when the language is changed #6341

ioanarusiczki opened this issue Sep 21, 2018 · 4 comments
Labels
component:collections state:stale Issues marked as stale. These can be re-opened should there be plans to fix them. type:bug

Comments

@ioanarusiczki
Copy link

STR:

  1. Load AMO dev and open one of your collections
  2. Click Edit collection details, make some changes (edit the text)
  3. Change the language
  4. Observe the screen

Actual results:
Collection's page is displayed not the edit page and edited text is lost.

Expected results:
The Edit collection page is still displayed.

Notes:
This issue is reproducible on AMO dev and AMO stage with FF62(Win10).

language3

@willdurand
Copy link
Member

I think that's because there is a page reload, no?

@ioanarusiczki
Copy link
Author

@willdurand Yes, just like in any screen actually - when another language is selected from the page's footer is looks like it reloads.

@kumar303
Copy link
Contributor

Yeah, this would be nice to fix. Using Redux for language changes will be hard, though, since it may require some hacks to our "dynamic" locale loader code.

Here is an issue about using Redux for language changes: #1640

I'm going to keep both open, though, because this one provides a concrete example of a bug that can be fixed. The older issue is written from a very technical perspective which could be confusing.

@stale
Copy link

stale bot commented Sep 18, 2019

This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.

@stale stale bot added the state:stale Issues marked as stale. These can be re-opened should there be plans to fix them. label Sep 18, 2019
@stale stale bot closed this as completed Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:collections state:stale Issues marked as stale. These can be re-opened should there be plans to fix them. type:bug
Projects
None yet
Development

No branches or pull requests

3 participants