Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing a developer reply from a permalink is visually awkward #12405

Closed
kumar303 opened this issue Sep 21, 2018 · 6 comments · Fixed by mozilla/addons-frontend#6442
Closed

Comments

@kumar303
Copy link
Contributor

kumar303 commented Sep 21, 2018

Describe the problem and steps to reproduce it:

  • Sign in as a developer
  • Go to one of your add-ons that has some reviews
  • Go to the review listing
  • Reply to a review
  • Click the timestamp of the review to view its detail page
  • From the detail page, click Edit my review

What happened?

It looks like:

screenshot 2018-09-21 16 22 28

What did you expect to happen?

  • There shouldn't be any stars
  • You should only see one review form. Multiple forms are open because the reply is also rendered further down in the listing.
  • The link to edit should have been Edit my reply
  • The buttons should say Update reply, etc

Anything else we should know?

@AlexandraMoga
Copy link

If you venture on selecting a star, an error message will also be displayed:

image

@bobsilverberg
Copy link
Contributor

@kumar303 maybe a change landed since you reported this, but there is one aspect of your report I cannot reproduce. You say:

The link to edit should have been Edit my reply

I do see "Edit reply" as the link in the featured review card:

screenshot 2018-09-26 15 37 50

Is that bug no longer valid, or am I misunderstanding?

@kumar303
Copy link
Contributor Author

I do see "Edit reply" as the link in the featured review card

Yep, this is fixed now. I crossed it out in the description. It looks like the other things I mentioned in the description still need fixing.

@ioanarusiczki
Copy link

@kumar303 I verified this issue on AMO dev with FF62(Win10) and the "Review" or star ratings are no longer available for the developer response.
The page must be refreshed to see the updated text down below in the list of reviews. Same if the response is edited from the list of reviews, not a big issue but let me know if we should track this with another issue.

updated with refresh

Also I filed #2066

@bobsilverberg
Copy link
Contributor

The page must be refreshed to see the updated text down below in the list of reviews. Same if the response is edited from the list of reviews, not a big issue but let me know if we should track this with another issue.

I opened #12447, which I think addresses the issue you describe. Do you agree @ioanarusiczki?

@ioanarusiczki
Copy link

@bobsilverberg Yes, I agree. It's in here #12447

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment