Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Flag" should be removed from the profile page #12433

Closed
ioanarusiczki opened this issue Sep 26, 2018 · 3 comments · Fixed by mozilla/addons-frontend#6620
Closed

"Flag" should be removed from the profile page #12433

ioanarusiczki opened this issue Sep 26, 2018 · 3 comments · Fixed by mozilla/addons-frontend#6620

Comments

@ioanarusiczki
Copy link

ioanarusiczki commented Sep 26, 2018

STR:

  1. Load AMO dev and go to the user profile page, make sure you have some reviews
  2. Observe the buttons displayed

Expected result:
Edit reviews and Delete review are available.

Actual result:
Flag is present too - it has no functionality since the user cannot flag his own reviews (or developer responses)

Notes:
Issue is reproducible on AMO dev with FF62 -Win10

own reviews cannot be flagged

@seanprashad
Copy link

seanprashad commented Oct 12, 2018

Hey @ioanarusiczki, @kumar303 - I'd like to help work on this bug if it's available!

I was able to still reproduce it just now on FF 62.0.3 with Mojave OS:

amo_bug_reproducable

From my understanding, a solution would to completely remove it from being rendered for reviews by the current user?

@kumar303
Copy link
Contributor

@seanprashad has fixed the issue 🎉 but his fix went further to not show the Flag link for a user's own review on any page. @ioanarusiczki please take a look at the other screens where we used to show the Flag link.

@ioanarusiczki
Copy link
Author

@kumar303 I checked the profile page and the reviews page for reviews and developer replies for an admin account and a developer account and "Flag" is no longer displayed. Tested on AMO dev with FF62 (Win10 & Android 8.0)
Thanks @seanprashad for fixing this!

flag is gone

@KevinMind KevinMind transferred this issue from mozilla/addons-frontend May 5, 2024
@KevinMind KevinMind added repository:addons-frontend Issue relating to addons-frontend migration:2024 labels May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

6 participants