Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lint rule to prevent logging objects #12480

Closed
kumar303 opened this issue Oct 4, 2018 · 0 comments · Fixed by mozilla/addons-frontend#6930
Closed

Add lint rule to prevent logging objects #12480

kumar303 opened this issue Oct 4, 2018 · 0 comments · Fixed by mozilla/addons-frontend#6930
Assignees
Labels
qa:not_needed repository:addons-frontend Issue relating to addons-frontend
Milestone

Comments

@kumar303
Copy link
Contributor

kumar303 commented Oct 4, 2018

In #12415 we got DOS'd by our own log message that was logging a large object, thus allocating a lot of memory. Can we add a lint rule to prevent logging objects? Even if it were naive and just prevented passing non-string arguments to log.info(), that might be good enough. Lint rules can always be disabled -- it will at least make the developer think about the implications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:not_needed repository:addons-frontend Issue relating to addons-frontend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants