Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test case for onLocationChanged helper function/action #12502

Closed
willdurand opened this issue Oct 9, 2018 · 1 comment · Fixed by mozilla/addons-frontend#6595
Closed

Add a test case for onLocationChanged helper function/action #12502

willdurand opened this issue Oct 9, 2018 · 1 comment · Fixed by mozilla/addons-frontend#6595
Assignees
@willdurand
Labels
component:code_quality migration:no-jira migration:2024 qa:not_needed repository:addons-frontend Issue relating to addons-frontend state:pull_request_ready
Milestone
2018.10.18

Comments

@willdurand
Copy link
Member

See: mozilla/addons-frontend#6466 (comment)

The idea is to make sure our version of onLocationChanged does not get out of sync with the upstream lib.
@willdurand willdurand self-assigned this Oct 9, 2018
@willdurand willdurand mentioned this issue Oct 9, 2018
Merged
9 tasks
@willdurand
Copy link
Member Author

I filed supasate/connected-react-router#158 because we never know :)

@willdurand willdurand added this to the 2018.10.18 milestone Oct 10, 2018
@willdurand willdurand mentioned this issue Oct 11, 2018
Merged
@KevinMind KevinMind transferred this issue from mozilla/addons-frontend May 5, 2024
@KevinMind KevinMind added repository:addons-frontend Issue relating to addons-frontend migration:2024 labels May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@willdurand willdurand

Labels
component:code_quality migration:no-jira migration:2024 qa:not_needed repository:addons-frontend Issue relating to addons-frontend state:pull_request_ready
Projects
None yet
Milestone
2018.10.18
Development

Successfully merging a pull request may close this issue.

Add a test case for onLocationChanged mozilla/addons-frontend
2 participants
@willdurand @KevinMind