Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad Word "AltRight" conflicts with KeyboardEvent.code "AltRight" #2151

Closed
sixcious opened this issue Aug 18, 2018 · 1 comment
Closed

Bad Word "AltRight" conflicts with KeyboardEvent.code "AltRight" #2151

sixcious opened this issue Aug 18, 2018 · 1 comment

Comments

@sixcious
Copy link

Describe the problem and steps to reproduce it:

The KeyboardEvent.code returns the String AltRight when the Alt Right modifier key is pressed. When developers write extensions that need to check for the return value of this specific key's event, they'll see a warning that their code violates Mozilla's policy. I am guessing this may be due to the conflict with the Bad Word altright in badwords.json.

In #1656, the Bad Word alt-right was originally in the list, but was removed/replaced due to a conflict with a 3rd party JS library called Ace.js that apparently uses alt-right in its code. However, the correct spelling of the term according to Wikipedia is indeed Alt-right. Also, IMO, the standardized JS KeyboardEvent.code should supersede the 3rd party library Ace.js on priority on this.

I suggest replacing the Bad Word altright with alt right (space), or revert back to the correct spelling alt-right (hyphen), or perhaps maybe even renaming it alternative right. What do you all think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants