Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 'browser_specific_settings' as an alias to 'applications' in the manifest #2280

Closed
wagnerand opened this issue Nov 15, 2018 · 3 comments · Fixed by #2296
Closed

Comments

@wagnerand
Copy link
Member

wagnerand commented Nov 15, 2018

Following mozilla/addons#6180, let's add support for browser_specific_settings to the linter as well.

I haven't checked in detail what needs to be updated, but there are a few code paths that touch applications. We should probably also have at least one test that uses browser_specific_settings.

Note: This should already be in the schema, if I understand correctly, added as part of https://bugzilla.mozilla.org/show_bug.cgi?id=1262005.

@eviljeff
Copy link
Member

btw, browser_specific_settings seems to have been scrubbed from MDN now (apart from a reference on https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Browser_compatibility_for_manifest.json describing browser_specific_settings as a "non-standard" variant of applications).

@wagnerand
Copy link
Member Author

@eviljeff yes, we reverted the changes on MDN until this has landed on prod.

@AlexandraMoga
Copy link

Verified fixed on AMO -dev with FF63, Win10x64

Extensions using browser_specific_settings in the manifest are treated equally as those using applications

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment