Make hidden and action mutually exclusive

[willdurand]

Hidden extensions should ideally not have any browser actions because it is a bit odd to not see the extension anywhere (e.g., not in about:addons) but still see a button in the toolbar and no way to remove the extension for instance. FTR, extensions can only be "hidden" if they are privileged extensions. That isn't possible for "regular" extensions.

We currently don't have any privileged extensions with browser actions but there is no restriction. We are going to make that happen in Firefox but it would be good to emit an error too.

[ioanarusiczki]

@rpl @willdurand

I tried with linter version 5.14.0 using a mozilla-signed extension to add browswer_action and page_action into manifest.json.

I didn't get an error with my testing sample. I'm attaching it, maybe I'm doing something wrong?

test2.zip

[willdurand]

This is only for privileged extensions with hidden: true in the manifest.json file and one (or all) of browser_action, page_action and action.

[ioanarusiczki]

@willdurand Ok, thanks, I'll add hidden, I was suspecting I'm missing something but I did not find hidden as property so I wasn't sure how to use it.

[ioanarusiczki]

@willdurand

I get the error message locally while testing it with --privileged flag and "hidden":true. Here's action property used in MV3:

I've also noticed that on the testing servers (AMO dev) this error is not available. Is this expected? Maybe these addons are uploaded with web-ext (It's just an assumption).

[willdurand]

I've also noticed that on the testing servers (AMO dev) this error is not available. Is this expected? Maybe these addons are uploaded with web-ext (It's just an assumption).

Yes, it is expected I think. The linter shouldn't be executed with the --privileged flag on AMO

[willdurand]

I get the error message locally while testing it with --privileged flag and "hidden":true. Here's action property used in MV3:

That looks good to me.