Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement linter validation result serializer #6380

Closed
EnTeQuAk opened this issue Feb 7, 2019 · 3 comments
Closed

Implement linter validation result serializer #6380

EnTeQuAk opened this issue Feb 7, 2019 · 3 comments
Labels
component:api component:code_manager component:reviewer_tools migration:no-jira migration:2024 repository:addons-server Issue relating to addons-server state:stale Issues marked as stale. These can be re-opened should there be plans to fix them. triaged

Comments

@EnTeQuAk
Copy link
Contributor

EnTeQuAk commented Feb 7, 2019

In #6287 I only added a link to the linter validation result but thinking about this more I think it makes sense to actually implement a serializer that can control and adjust data as we need it.

@willdurand @bobsilverberg when touching this, does it make sense for you to inline the contents validation_url_json into the browse API directly? Otherwise, I may make this a separate endpoint to request results (instead of exposing that URL as I did) or just inline the information. On the other hand, for bigger files, and diffs, that may end up being quite a bit of content so retrieving it in a second step sounds reasonable to me.

@bobsilverberg
Copy link
Contributor

As I understand it, we'll only need this information when looking at a specific file - is that correct? If so then I think it makes sense to inline it with the API response that returns the file's contents. @EnTeQuAk and I also discussed today having a separate endpoint for an individual file (which could include its contents and this validation info) apart from an endpoint that returns the file entries used to build the file tree.

@kumar303
Copy link
Contributor

kumar303 commented Mar 4, 2019

@EnTeQuAk we realized that we do need to get the linter result from a separate endpoint because the compare/diff view also needs to show linter messages. Thus, we can begin using the existing validation.json URL. No need to prioritize a new endpoint over that one.

@stale
Copy link

stale bot commented Nov 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.

@stale stale bot added the state:stale Issues marked as stale. These can be re-opened should there be plans to fix them. label Nov 7, 2020
@stale stale bot closed this as completed Nov 21, 2020
@KevinMind KevinMind transferred this issue from mozilla/addons-server May 4, 2024
@KevinMind KevinMind added repository:addons-server Issue relating to addons-server migration:2024 labels May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:api component:code_manager component:reviewer_tools migration:no-jira migration:2024 repository:addons-server Issue relating to addons-server state:stale Issues marked as stale. These can be re-opened should there be plans to fix them. triaged
Projects
None yet
Development

No branches or pull requests

5 participants