Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create API to expose primary shelf config to frontend #6819

Closed
eviljeff opened this issue Jul 15, 2019 · 3 comments · Fixed by mozilla/addons-server#11858
Closed

create API to expose primary shelf config to frontend #6819

eviljeff opened this issue Jul 15, 2019 · 3 comments · Fixed by mozilla/addons-server#11858

Comments

@eviljeff
Copy link
Member

all the admin model data needs to be exposed in a single API endpoint for frontend to consume

@AlexandraMoga
Copy link

@eviljeff I tried to figure out what can be tested at this point, but I can't find much.
I've noticed the new /hero/ endpoint but apart form verifying that the api calls are working, there isn't any data to validate.
I've also tried to generate data from the new "Hero" admin model but this tool doesn't seem to be finished yet.

If there is anything else that I could verify at this point please let me know.

@eviljeff
Copy link
Member Author

It will be easier when #6813 is complete, yes, but it should be possible now to create a PrimaryHero instance, link it to a DiscoveryAddon and set some details. Nothing is validated though, and the details for the DiscoveryItem are only viewable/editable via the discovery admin at this point.

It won't be used on production for quite a while so there's no urgency to verify.

@AlexandraMoga
Copy link

Verified fixed on -dev
Both endpoints are returning the add-on details with the hero customization added in Discovery items.
GET /api/v4/hero/ - brings only one add-on randomly selected from the pool of Enabled primary heroes
GET /api/v4/hero/primary - brings the list of all Primary heroes enabled at a given moment

*Note: the description field will return the Custom description string added for the discovery item whenever this information is available. Otherwise, description will default to the add-on summary.

@KevinMind KevinMind transferred this issue from mozilla/addons-server May 4, 2024
@KevinMind KevinMind added repository:addons-server Issue relating to addons-server migration:2024 labels May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants