Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate MLBF for v3 blocklist and submit to kinto as attachment #7359

Closed
eviljeff opened this issue Mar 2, 2020 · 7 comments · Fixed by mozilla/addons-server#13659
Closed

Comments

@eviljeff
Copy link
Member

eviljeff commented Mar 2, 2020

We need to build on the proof of concept for #7290 to save the blocklist as an attachment to a kinto record.

@AlexandraMoga
Copy link

@eviljeff is there anything that I could test for this?

@eviljeff
Copy link
Member Author

@eviljeff is there anything that I could test for this?

if you enable the blocklist_mlbf_submit waffle switch on -dev you will see regular records created with an attachment in https://kinto.dev.mozaws.net/v1/buckets/blocklist/staging_amo_dev/collections/addons-mlbf/ - once every 6 hours. (next one would be scheduled for 12:00 UTC, and then 18:00 UTC, etc.)

@eviljeff
Copy link
Member Author

it's not possible to interpret the bloom filter attachment manually, but you can see it's there, is non-0, and would change in the next 6 hours if a block was added/deleted (and possibly if a new addon/version was uploaded to AMO, but it depends on some complicated maths).

Don't enable the switch on stage yet, it's blocked there by https://bugzilla.mozilla.org/show_bug.cgi?id=1619994 and some other followup.

@AlexandraMoga
Copy link

@eviljeff
Copy link
Member Author

whoops, I meant: https://kinto.dev.mozaws.net/v1/buckets/staging_addons_dev_allizom_org/collections/addons-mlbf/records - note the server gets reset every day (I don't know when exactly - sometime after the 06:00 filter was uploaded) so looks like you'd have to check after 12:00UTC

@AlexandraMoga
Copy link

I was able to see the information today after 12:00 UTC. I'm going to look again tomorrow to see if anything changes if blocks have been added or or deleted.

@AlexandraMoga
Copy link

I've compared the previous data from https://kinto.dev.mozaws.net/v1/buckets/staging_addons_dev_allizom_org/collections/addons-mlbf/records with the new data generated today and the contents have changed, since there have been updates made to blocklist entries on AMO.

So, based on these observations I will mark the issue as verified fixed.

@KevinMind KevinMind transferred this issue from mozilla/addons-server May 4, 2024
@KevinMind KevinMind added repository:addons-server Issue relating to addons-server migration:2024 labels May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants